search

Planimeter / hl2sb-src

Source code to Half-Life 2: Sandbox - A free and open-source sandbox Source engine modification.
MIT License
43 stars 9 forks source link

SetObserverTarget function missing #5

Open Dim1xs opened 6 months ago

Dim1xs commented 6 months ago

Lua has everything for enabling Observer mode for player, but it dont has a function SetObserverTarget. That's kinda bad.

GuestSneezeOSDev commented 2 months ago

@Dim1xs is this still an issue?

Dim1xs commented 2 months ago

@GuestSneezeOSDev of course

andrewmcwatters commented 2 months ago

@Dim1xs @GuestSneezeOSDev That's odd that we never implemented this. Looks like it's from the client-side CBasePlayer class?

GuestSneezeOSDev commented 2 months ago

@Dim1xs Have you edited the source code in any way?

Dim1xs commented 2 months ago

@andrewmcwatters I think you could, i found that function in player.h and in c_baseplayer.h, and i found also that SetBodygroup for Server-side of Lua CBaseAnimating is missing too.

Dim1xs commented 2 months ago

@GuestSneezeOSDev nope, current source code doesn't compiles for me.

GuestSneezeOSDev commented 2 months ago

@andrewmcwatters I recommend merging #7

andrewmcwatters commented 2 months ago

@GuestSneezeOSDev I'd like to, too, but there's a number of minutiae that need to be addressed. It's on my backlog. That codebase evolved from 2006 -> 2007 -> 2013, so there's some large scale manual diff review that needs to go on.

Luckily, we mostly wrapped our diffs around HL2SB #ifdefs to make these ports overtime easy to handle, but it's still a large chore. And we never really adopted VPC, having a single target we were allowed to publish to since we weren't licensees. We simply patched the built project files and pushed them up over the years.

andrewmcwatters commented 2 months ago

@GuestSneezeOSDev In theory, you should be able to check out a fresh copy of 2013, literally drop hl2sb-src on top of it, and see what changes there are wrapped in HL2SB ifdefs.

GuestSneezeOSDev commented 2 months ago

I could potentially port the 2006 version of HL2SB to the 2013 branch of the Source Engine

andrewmcwatters commented 2 months ago

@GuestSneezeOSDev I don't think too much really changes between them. It's really the engine itself, iirc. I'm not sure how much of the newer engine features we expose to Lua between the engine branches.