search

Plankske / hb-virtual-switch

Use hb-virtual-switch to configure virtual switches that are triggered by keywords appearing in the Homebridge log file, as well as to configure traditional virtual (dummy( switches.
Apache License 2.0
1 stars 0 forks source link

Resettable switch option #4

Open Olivierbkk opened 1 month ago

Olivierbkk commented 1 month ago

In the Homebridge dummy plugin, there is the option to make the switch resettable. Could you add this to your plugin?

image

Plankske commented 1 month ago

Let me check this out. Give me some time to look into this.

On Oct 5, 2024, at 7:57 PM, Olivierbkk @.***> wrote:



In the Homebridge dummy plugin, there is the option to make the switch resettable. Could you add this to your plugin?

image.png (view on web)https://github.com/user-attachments/assets/b0688d4d-c7fb-4f3b-a933-ab7d6a762b9d

— Reply to this email directly, view it on GitHubhttps://github.com/Plankske/hb-virtual-switch/issues/4, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APYHGAXWL5HCVPRJMXKTVHTZ2CKIFAVCNFSM6AAAAABPN3LQOSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU3DQNBRGUZDKOI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Olivierbkk commented 1 month ago

No rush, buddy... your plugin will certainly replace the HB dummy plugin but it's not really needed until HB2.0 is out

Plankske commented 1 week ago

To clarify - resettable means that if the timed switch is in its triggered state (say was turned ON for 2 minutes) is triggered again (say turned ON by some automation), do you want the timer to reset to 2 minutes again? If this is not what is understood by it, please clarify and I will see what I can do. If it is what I described above, it is active now in v.1.2.1
Lmk.

Olivierbkk commented 1 week ago

Yes it’s correct. I tried it and it works, thanks!

I noticed you didn’t make this feature optional which is fine for my current use case but might not work for everyone else.

There is a bug to fix also, with persistent timer enabled, when I restart Homebridge, the switch is always on, even if it was off prior to restarting and doesn’t turn off even after the timer has elapsed. I have to manually turn it off and then it works as intended.

Plankske commented 1 week ago

Thanks for the clarification. Will look into ‘unresettable’ later. Re the persistence bug, I hope to push an update tomorrow.

From: Olivierbkk @.> Sent: Monday, November 18, 2024 8:48:32 PM To: Plankske/hb-virtual-switch @.> Cc: Plankske @.>; Comment @.> Subject: Re: [Plankske/hb-virtual-switch] Resettable switch option (Issue #4)

Yes it’s correct. I tried it and it works, thanks!

I noticed you didn’t make this feature optional which is fine for my current use case but might not work for everyone else.

There is a bug to fix also, with persistent timer enabled, when I restart Homebridge, the switch is always on, even if it was off prior to restarting and doesn’t turn off even after the timer has elapsed. I have to manually turn it off and then it works as intended.

— Reply to this email directly, view it on GitHubhttps://github.com/Plankske/hb-virtual-switch/issues/4#issuecomment-2484535684, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APYHGASDMCNVENJWWDXESEL2BKKHBAVCNFSM6AAAAABPN3LQOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBUGUZTKNRYGQ. You are receiving this because you commented.Message ID: @.***>