search

PlanktoScope / device-backend

All backend software underneath the PlanktoScope device's standard API
GNU General Public License v3.0
2 stars 6 forks source link

Reduce default brightness of illumination LED for pscopehat controller #14

Closed LaurentPV closed 9 months ago

LaurentPV commented 9 months ago

Here is a pull request concerning the bugfix for https://github.com/PlanktoScope/PlanktoScope/issues/259 on the overexposure issue. A test was conducted by Thibaut and Laurent on the 2023-11-29 and concluded with the DEFAULT_CURRENT value of 10mA.

ethanjli commented 9 months ago

Good work! I will add an item to the CHANGELOG.md file describing this change as a fix, and then I'll approve the PR for merging.

ethanjli commented 9 months ago

@LaurentPV if my note on the changelog looks good to you, GitHub wants you to approve the pull request, and then you can go ahead and merge this PR.

ethanjli commented 9 months ago

@LaurentPV It looks like you're busy, and I'd like to include this in the v2023.9.0-beta.2 prerelease, which I'm trying to publish today (or else tomorrow). So I will go ahead and merge this PR without an approving review, using my administrator permissions.