search

PlanktoScope / device-backend

All backend software underneath the PlanktoScope device's standard API
GNU General Public License v3.0
2 stars 6 forks source link

Make EcoTaxa metadata TSV file names unique per dataset #40

Closed RomainFauvel closed 1 month ago

RomainFauvel commented 3 months ago

This PR will contribute to (or maybe fix?) https://github.com/PlanktoScope/PlanktoScope/issues/213

Description

This pull request has for objective to :

What it does

  1. Name tsv file with the acq_id

Instructions for testing this PR

To test new changes to this PR on a PlanktoScope with internet access:

  1. Push your changes in one or more commits up to the fix/ecotaxa-metadata-filename branch
  2. Wait for the CI checks/workflows on this PR to finish rebuilding the Docker container image for the segmenter. You should see a new entry at https://github.com/PlanktoScope/device-backend/pkgs/container/device-backend-processing-segmenter with a label (e.g. sha-55e23d1) corresponding to the latest commit (e.g. 55e23d1 ) which you had pushed to the branch. It should also have the label pr-40 attached.
  3. Go to the Cockpit Terminal of the PlanktoScope (usually this will be at http://planktoscope.local/admin/cockpit/system/terminal, or else you can access Cockpit from the PlanktoScope's landing page and then you can access the terminal from Cockpit's sidebar).
  4. Run the following command: forklift pallet switch github.com/PlanktoScope/pallet-standard@fix/ecotaxa-metadata-filename (note: the URL given here corresponds to https://github.com/PlanktoScope/pallet-standard/pull/14, which deploys the pr-40 version of the Docker container image for the segmenter).
  5. Either reboot your PlanktoScope or run: sudo systemctl start forklift-apply. This command will disconnect Cockpit in your browser tab; if you wait ~10 seconds and refresh your browser tab, then you should be able to log in to Cockpit again.

Afterwards, the updated segmenter should be running. You can check its live-updating logs with Dozzle (usually the logs will be at http://planktoscope.local/admin/dozzle/show?name=apps_ps_backend_proc-segmenter-server-1, or else you can access the live-updating logs from a link in the Node-RED dashboard's "Administration" page).

ethanjli commented 3 months ago

In the 2024-07-11 software meeting, Romain and I discussed giving some work to Oumayma, and we decided to have @Oumayma-hy take over this PR. Oumayma: can you see if you're able to make a change to files directly on the branch associated with this PR? e.g. add a code comment to one of the files, commit and push, and then delete that code comment and commit and push again.