search

PlanktoScope / device-backend

All backend software underneath the PlanktoScope device's standard API
GNU General Public License v3.0
2 stars 6 forks source link

Initialize camera image gain to a consistent ISO of 150 #48

Closed ethanjli closed 3 weeks ago

ethanjli commented 3 weeks ago

This PR is part of a fix for a regression reported to me (privately, in DMs) by @fabienlombard on PlanktoScope OS v2024.0.0-beta.1, in which the default ISO setting displayed on the Node-RED dashboard was inconsistent with the actual initial image gain (of 1.0, which corresponds to an ISO of ~54 on the PlanktoScope hardware v2.1's camera and an ISO of ~43 on the PlanktoScope hardware v2.3+'s camera). This PR initializes the image gain value to match a consistent ISO setting of 150, which will become the default ISO setting for both the adafruithat Node-RED dashboard and the planktoscopehat Node-RED dashboard.

This fix was discussed and approved in the 2024-07-25 software meeting.

ethanjli commented 3 weeks ago

I tested this PR in https://github.com/PlanktoScope/PlanktoScope/pull/467 and it seems to work, so I will merge this PR.