Plant-Tracer / webapp

Client and Server for web-based JavaScript app
GNU Affero General Public License v3.0
0 stars 2 forks source link

Authentication error message too revealing #565

Open sbarber2 opened 3 days ago

sbarber2 commented 3 days ago

I browsed to http://localhost:8080/audit after logging out, and the server returned this error page:

"Authentication error 403 api_key is None and require_auth is True"

Screenshot 2024-10-12 at 11 02 49 AM

I think that message gives too much information from a security standpoint, and the usual "403 Forbidden" would be about the right level of disclosure.

That said, it would be nice to maintain the current message if running in debug mode (or perhaps to put into the server log).

simsong commented 2 days ago

I don't think that it's too much information from a security standpoint. But that's your decision.