search

Plant-Tracer / webapp

Client and Server for web-based JavaScript app
GNU Affero General Public License v3.0
1 stars 2 forks source link

Download Movie #607

Open sbarber2 opened 1 month ago

sbarber2 commented 1 month ago

It would be nice if users could download movies.

How many times have I wanted to download a movie in the dev.planttracer.com instance so I could use it in my local instance? Many.

It's probably a use case that users in a course will want to share movies in the sense that they may want to do different tracking runs with different marker positions.

I strongly suspect this feature will want access control.

Quick take on what those access rules might be:

Yes, of course, users could manage their own movies files elsewhere and share them that way, but being able to download movies from the app is just going to be handy.

simsong commented 1 month ago

You can. Click 'play' and then right-click:

image
sbarber2 commented 1 month ago

A fair point. So much for access control (if that was ever desired).

OK, that works, more or less.

I tried this in Chrome against dev.planttracer.com on the movie with id 5724. It downloaded the movie to a file named 5724-243a.mov

In MacOS Safari, the file is named get-movie-data with no extension.

In MacOS Firefox (131.0.3), pressing Play on the Movies page for this movie doesn't work, so that'll be a new Issue. (#608)

We can document this for users, as they won't all think of it on their own.

But I'd say given these results, if Download Movie is to be a positive feature of the webapp (rather than an artifact of the browser environment as it is now), then we have some work to do in order to make it both nice and friendly and a bit more user-proof.

simsong commented 1 month ago

We could certainly create a download link that just downloads the movie if you want that. It's about 5 min to change, just some HTML and JS.