search

Plant-for-the-Planet-org / FireAlert

Monitor Forest Fires with FireAlert
https://www.plant-for-the-planet.org/firealert
Other
7 stars 1 forks source link

Don't notify follow up Fire Alerts for same date/time #96

Closed sagararyal closed 9 months ago

sagararyal commented 1 year ago

In this case, the first fire was reported within 30 hrs. However, as there was delay in reporting, subsequent fires detected at the same time were still being triggered 2 days after the fire.

If a site has a fire recently The expected behavior would be to check if the fire occurred after x time →eg 2 hrs, and if the alert was within 12 hrs. Otherwise, the purpose of emergency alert wouldn't be as good.

Screenshot 2023-11-09 at 8 12 56 PM
dhakalaashish commented 9 months ago

These PRs fix the issue:

95 #103 #109 #110

dhakalaashish commented 9 months ago

144 contains optimizations and improvements on the createNotification code.