search

Plant-for-the-Planet-org / planet-donations

The Donation Gateway that powers the Plant-for-the-Planet Platform. You can make donations to restoration organizations, plant trees and support forest conservation.
https://donate.plant-for-the-planet.org
Other
7 stars 5 forks source link

Fixes bugs with Planetcash selector #460

Closed mohitb35 closed 10 months ago

mohitb35 commented 10 months ago

Bugs fixed

  1. Planetcash toggled on automatically after disabling - introduced by #447
  2. Planetcash switch turned on automatically after updating the amount or editing gift details
  3. Resolves issues with paying into planetcash using native payments - payment failure, incorrect amount after visiting from the Add Balance button while on the project page - by making sure to refresh paymentRequest on every change to country, currency, amount.

Also:

  1. Resolves an issue of jerky layout seen when Google Pay / Apple Pay buttons were present and amount was refreshed.
  2. Enables login to vercel deployments with custom domains (e.g. applepay.pp.eco) without redirecting to the dynamic preview url. This is to be used for testing only, by setting the DISABLE_VERCEL_REDIRECT env to "true"
vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
donate-with-planet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 10:47am
mohitb35 commented 10 months ago

@mariahosfeld now planetcash payments using native payment methods also work.

norbertschuler commented 10 months ago

Everytime I login and pay with my PlanetCash the donation is done, but I do not see a thank you page, but stay on this page where the payment button is greyed out as following - for paydev.pp.eco one gets correctly redirected to a thank you page:

Bildschirmfoto 2024-01-17 um 11 13 31
mohitb35 commented 10 months ago

verytime I login and pay with my PlanetCash the donation is done, but I do not see a thank you page, but stay on this page where the payment button is greyed out as following - for paydev.pp.eco one gets correctly redirected to a thank you pag

I don't see this issue, it gets correctly redirected. Could you demonstrate this?

norbertschuler commented 10 months ago

I don't see this issue, it gets correctly redirected. Could you demonstrate this?

It is a different problem of its own which can be solved separatly:

  1. I did a donation before and so reached a page as e.g. https://donate-with-planet-873uy0mu7-planetapp.vercel.app/de?step=thankyou&to=plants-for-life (which step=thankyou as part of the URL)
  2. Lazy as I am I reloaded that page in the browser to show the first page again, but the step=thankyou persisted in the URL.
  3. Doing a PlanetCash payment then results in staying on this screen probably as the software does not redirect to the thank you page as it already is part of the current URL.