search

Plant-for-the-Planet-org / planet-webapp

The Open Source and Commission Free Application that powers the Trillion Tree Campaign. Visit us to meet reforestation Organizations, individuals and companies who are on a journey to plant, monitor and restore a trillion trees.
https://www.trilliontreecampaign.org
Other
34 stars 14 forks source link

Resolve multiple api calls in data explorer #2055

Closed prachigarg19 closed 4 months ago

prachigarg19 commented 4 months ago

Description

There are multiple api calls being made at below places:

  1. When adding a HID or selecting a date in the HID/Date filter, the application is making excessive API calls. Specifically, every time the user presses the backspace key in the input field, a new API call is triggered, leading to unnecessary server requests and potentially impacting performance.
  2. In the Data Explorer section, selecting dates in the From or To fields triggers an API call each time a date is chosen from the calendar.

Expected behavior

For first point, debouncing should be implemented to reduce the number of calls per second

In the second point, API calls should be made only after the user has finalized their date selection, rather than for each individual date chosen from the calendar.

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

The recent updates aim to refine user interaction and data management in the TreeMapper application. The Map component now includes a delayed data fetching mechanism for enhanced performance, while the Project Filter component introduces local state management for date selection, empowering users with more precise control over date filters.

Changes

File Path Change Summary
.../Analytics/components/Map/index.tsx Added a delayed fetch operation using setTimeout in MapContainer to optimize data fetching timing.
.../Analytics/components/ProjectFilter/index.tsx Implemented local state management for date selection in ProjectFilter to elevate user input control.

🐇✨ Oh, hark! A change does bloom, In the garden of our code's room. Delays in fetch, a thoughtful pause, Dates held close, without a flaw. Hop and tweak, with care we thread, Through lines of logic, our path we tread. 🌼🍃

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planet-webapp ✅ Ready (Inspect) Visit Preview May 6, 2024 9:53am
planet-webapp-multi-tenancy-setup ✅ Ready (Inspect) Visit Preview May 6, 2024 9:53am
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **planet-webapp-temp** | ⬜️ Ignored ([Inspect](https://vercel.com/planetapp/planet-webapp-temp/J3m1Edhkhjdo6d1PszTQ7rJoou3h)) | | | May 6, 2024 9:53am |
norbertschuler commented 4 months ago

We once upon a time invented https://github.com/Plant-for-the-Planet-org/planet-webapp/blob/develop/src/utils/useDebouncedEffect.ts to throttle the projects search to not trigger it for every single input change of the users in the search field. Maybe this concept would also be useful here?

prachigarg19 commented 4 months ago

Works, but a little bit ugly code now having two hooks and also the type check for the paramters for useDebouncedEffect is failing now of course. (I fixed some wrong label on the page saying "from" instead of "to".)

I could reset the changes in this case.