Closed shyambhongle closed 3 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
planet-webapp | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 30, 2024 8:06am |
planet-webapp-multi-tenancy-setup | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 30, 2024 8:06am |
[!WARNING]
Rate limit exceeded
@mohitb35 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 34 minutes and 16 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 678e14cdea84fe7a2b0cec2939eb3f534d809b6c and 7c9f1b7e552a994b8a7718dd9fb5257eb413f06f.
The recent updates have improved the handling and rendering of plant locations on the map. Key changes include the introduction of new functions in ProjectsMap.tsx
to manage plant location selection and map loading, as well as refactoring PlantLocations.tsx
to use a new function for generating GeoJSON features. Additionally, type definitions for plant locations have been refined for better clarity and consistency.
Files | Change Summary |
---|---|
src/features/projects/components/ProjectsMap.tsx |
Added functions for handling plant location selection and map loading; updated component props and imports. |
src/features/projects/components/maps/PlantLocations.tsx |
Introduced makeInterventionGeoJson function to generate GeoJSON; refactored rendering logic for plant locations. |
src/features/common/types/plantLocation.d.ts |
Updated type properties and adjusted geometry property types for plant location interfaces. |
sequenceDiagram
participant User
participant ProjectsMap
participant PlantLocations
participant GeoJSON
User ->> ProjectsMap: Interacts with map
ProjectsMap ->> ProjectsMap: handlePlantLocationSelection
ProjectsMap ->> ProjectsMap: handleOnLoad
ProjectsMap ->> PlantLocations: Render plant locations
PlantLocations ->> GeoJSON: makeInterventionGeoJson
GeoJSON -->> PlantLocations: Return GeoJSON features
PlantLocations -->> ProjectsMap: Display locations on map
In the code, where plants do grow, 🌱
A map now shines with a gentle glow. ✨
Refactored logic, neat and clear,
GeoJSON whispers, "Locations here!"
With types refined and functions bright,
Our map now gleams in the soft moonlight. 🌕
Hooray for changes, done just right! 🎉
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Zooming is working better than in the current develope branch, but when I test this locally with npm run dev
I sometimes experiences this crash:
Zooming is working better than in the current develope branch, but when I test this locally with
npm run dev
I sometimes experiences this crash:
Yes, @Norbert, there are some known issues with the zoom-in functionality. Once this PR is merged, we will work on resolving these issues. Regarding the crash, is it specific to this PR, or can it be reproduced on the develop branch as well?
Zooming is working better than in the current develope branch, but when I test this locally with
npm run dev
I sometimes experiences this crash:Yes, @norbert, there are some known issues with the zoom-in functionality. Once this PR is merged, we will work on resolving these issues. Regarding the crash, is it specific to this PR, or can it be reproduced on the develop branch as well?
I cannot reproduce the crash on the develop branch.
@norbertschuler I couldn't reproduce the crash you mentioned while running this locally. Was it on a specific project? Or in any specific scenario?
@norbertschuler I couldn't reproduce the crash you mentioned while running this locally. Was it on a specific project? Or in any specific scenario?
I can not reproduce the above crash any more with the latest version now. On Vercel it works fine for me, locally with npm run dev
(also tested with npm run build & npm run start -p 3000
) the zooming does not always work. Check the attached video. But if it works on Vercel with the builded version I am fine.
Zoom works on the built version on Vercel, or at least it works as well as the current webapp on production. I think we can get this out, and handle the zoom issues separately.
Fixes
Changes in this pull request: Code refactor to improve map performance. Use of geoJSON filters instead of mapping.
@mohitb35