Feature/progress bar

[sunilsabatp]

UI for progress bar

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2024 7:31am
planet-webapp-multi-tenancy-setup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2024 7:31am

1 Ignored Deployment

| Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **planet-webapp-temp** | ⬜️ Ignored ([Inspect](https://vercel.com/planetapp/planet-webapp-temp/7feqXx1fqW7q2sBbMkHvq83Ker2Q)) | | | Jun 20, 2024 7:31am |

[coderabbitai[bot]]

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[sunilsabatp]

Most things are done, but one think remains (was not able to detect it before): When I disable a target on my phone, and - after refreshing the page - re-enable it on my computer, then the field on the computer is empty. Same thing happens when I disable on my computer, then the field on my phone is empty. After a refresh the fields are then also empty on the device where it was disabled.

To address this issue, we need to update the /app/profile endpoint. Specifically, we need to include a key in the profile response that keeps a record of the toggle state. Since it is not possible to manage toggle states on the client side, the state will be reset if the page is reloaded

[mariahosfeld]

Most things are done, but one think remains (was not able to detect it before): When I disable a target on my phone, and - after refreshing the page - re-enable it on my computer, then the field on the computer is empty. Same thing happens when I disable on my computer, then the field on my phone is empty. After a refresh the fields are then also empty on the device where it was disabled.

To address this issue, we need to update the /app/profile endpoint. Specifically, we need to include a key in the profile response that keeps a record of the toggle state. Since it is not possible to manage toggle states on the client side, the state will be reset if the page is reloaded

Lets move this point to later improvements.

[mohitb35]

1. The progress bars of adjacent cells looks unaligned if the one cell has community contributions, and the other does not. I think it should always be in the same line. If community contributions (gifts) are present, then they can be shown below the bar.
2. Check calculations for the percentage shown at the end of the bar, and the ratio of different portions of the bar. Test scenarios
   • Target = 100, gift=10, personal=25 >> percentage shown should be 35%, and gift portion of bar should be 10% width, personal portion should be 25% width, rest should be 65% width
   • Target = 0, gift=10, personal=25 >> no percentage will be shown. Gift portion of bar would be (10/35), personal portion of bar would be (25/35)
   • Target = 0, gift=10, personal=0>>no percentage will be shown. Gift portion of bar would be 100%
   • Target=0, gift =0, personal=0>> don't show item itself

[mohitb35]

When no targets are set, and no scores are available, the TargetInitialize component is shown.

1. Align the text and the button to the vertical center of the container.
2. The button looks too large. I've set up common buttons in #2083, so the button can be replaced after merging. Take a look and see if any adaptations need to be made.

[mohitb35]

Disable the switch when the field is empty (instead of reversing the change). Switch should appear disabled as well.

[mohitb35]

• [x] 1. Refactor progress bars to use a common component e.g ForestProgressItem containing ProgressData and EditTarget
• [x] 2. Refactor modal children to use a common component e.g TargetFormInput. You need to maintain local form state to avoid changes to the page until the user saves the data

[sunilsabatp]

When no targets are set, and no scores are available, the TargetInitialize component is shown.

1. Align the text and the button to the vertical center of the container.
2. The button looks too large. I've set up common buttons in Feature/my contributions #2083, so the button can be replaced after merging. Take a look and see if any adaptations need to be made.

I see the same dimension(147 x 45) on the Figma design -> https://www.figma.com/design/lT7AVzzAUM0NyThCyvacob/MyForest-Dashboard?node-id=2635-6591&t=dqO5GL8lJN9up6o3-4

[mohitb35]

1. Trees planted progress bar - a transparent white background is currently seen instead of the green background in the design
2. When I update a target and save, the targets and the bars do not update. They only update if I refresh the screen.
3. Translation strings need to be better named so that their purpose is clear for translators

[mohitb35]

@sunilsabatp Logic to enable switches for the target modal form has some slight issues, everything else is good.