Closed sunilsabatp closed 2 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
planet-webapp | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 20, 2024 7:31am |
planet-webapp-multi-tenancy-setup | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 20, 2024 7:31am |
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Most things are done, but one think remains (was not able to detect it before): When I disable a target on my phone, and - after refreshing the page - re-enable it on my computer, then the field on the computer is empty. Same thing happens when I disable on my computer, then the field on my phone is empty. After a refresh the fields are then also empty on the device where it was disabled.
To address this issue, we need to update the /app/profile endpoint. Specifically, we need to include a key in the profile response that keeps a record of the toggle state. Since it is not possible to manage toggle states on the client side, the state will be reset if the page is reloaded
Most things are done, but one think remains (was not able to detect it before): When I disable a target on my phone, and - after refreshing the page - re-enable it on my computer, then the field on the computer is empty. Same thing happens when I disable on my computer, then the field on my phone is empty. After a refresh the fields are then also empty on the device where it was disabled.
To address this issue, we need to update the /app/profile endpoint. Specifically, we need to include a key in the profile response that keeps a record of the toggle state. Since it is not possible to manage toggle states on the client side, the state will be reset if the page is reloaded
Lets move this point to later improvements.
When no targets are set, and no scores are available, the TargetInitialize component is shown.
Disable the switch when the field is empty (instead of reversing the change). Switch should appear disabled as well.
When no targets are set, and no scores are available, the TargetInitialize component is shown.
- Align the text and the button to the vertical center of the container.
- The button looks too large. I've set up common buttons in Feature/my contributions #2083, so the button can be replaced after merging. Take a look and see if any adaptations need to be made.
I see the same dimension(147 x 45) on the Figma design -> https://www.figma.com/design/lT7AVzzAUM0NyThCyvacob/MyForest-Dashboard?node-id=2635-6591&t=dqO5GL8lJN9up6o3-4
@sunilsabatp Logic to enable switches for the target modal form has some slight issues, everything else is good.
UI for progress bar