Plant-for-the-Planet-org / planet-webapp

The Open Source and Commission Free Application that powers the Trillion Tree Campaign. Visit us to meet reforestation Organizations, individuals and companies who are on a journey to plant, monitor and restore a trillion trees.
https://www.trilliontreecampaign.org
Other
31 stars 13 forks source link

Feature/my contributions #2083

Closed mohitb35 closed 1 month ago

mohitb35 commented 1 month ago

Changes:

  1. Implements MyContributions UI and functionality
  2. Sets up stories for all subcomponents
  3. Utilizes data from trpc contributions and projectList endpoints to populate list.

Pending - to be done in a separate PR

  1. Empty state management
  2. Loading management
  3. Minor background bleed issue for rounded outside borders while displaying gift label
  4. Responsiveness adjustments to be done in conjunction with other features on the page. e.g. https://github.com/Plant-for-the-Planet-org/planet-webapp/pull/2083#issuecomment-2162067308
vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planet-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 0:22am
planet-webapp-multi-tenancy-setup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 0:22am
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **planet-webapp-temp** | ⬜️ Ignored ([Inspect](https://vercel.com/planetapp/planet-webapp-temp/9CojdoXZghVsKLgwDG97GWtGzPhF)) | | | Jun 12, 2024 0:22am |
coderabbitai[bot] commented 1 month ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
sunilsabatp commented 1 month ago

It seems like the wrong default image has been used for the registered tree. from figma -> image

image

mohitb35 commented 1 month ago

It's the correct one

https://www.figma.com/design/lT7AVzzAUM0NyThCyvacob/MyForest-Dashboard?node-id=3680-1063&t=q1VD8ONzVOkm9VY4-4


From: sunilsabatp @.> Sent: Wednesday, June 12, 2024 9:18 AM To: Plant-for-the-Planet-org/planet-webapp @.> Cc: Mohit Bajaj @.>; Author @.> Subject: Re: [Plant-for-the-Planet-org/planet-webapp] Feature/my contributions (PR #2083)

It seems like the wrong default image has been used for the registered tree. from figma -> image.png (view on web)https://github.com/Plant-for-the-Planet-org/planet-webapp/assets/101264823/5262ecb9-6031-4b45-9fc0-86fd056ab8c2

image.png (view on web)https://github.com/Plant-for-the-Planet-org/planet-webapp/assets/101264823/1a0e3a1d-89ac-43be-9f1c-4a99d596fd41

— Reply to this email directly, view it on GitHubhttps://github.com/Plant-for-the-Planet-org/planet-webapp/pull/2083#issuecomment-2162050021, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKWWEY7WJ53C6TPFLAWCAJ3ZG7AKXAVCNFSM6AAAAABISGQXQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRSGA2TAMBSGE. You are receiving this because you authored the thread.Message ID: @.***>

sunilsabatp commented 1 month ago

The UI does not look good on the iPad version

image
sunilsabatp commented 1 month ago

The width of the button is incorrect on the public profile.

image
mohitb35 commented 1 month ago

The UI does not look good on the iPad version image

Agree, will be taken up as adjustments after all parts are merged to the base PR. That will help keep things consistent.

mohitb35 commented 1 month ago

The width of the button is incorrect on the public profile. image

Buttons are based in the designs here >> https://www.figma.com/design/lT7AVzzAUM0NyThCyvacob/MyForest-Dashboard?node-id=3459-807&t=q1VD8ONzVOkm9VY4-4

These are common buttons that can be used across the app.