Plant-for-the-Planet-org / planet-webapp

The Open Source and Commission Free Application that powers the Trillion Tree Campaign. Visit us to meet reforestation Organizations, individuals and companies who are on a journey to plant, monitor and restore a trillion trees.
https://www.trilliontreecampaign.org
Other
35 stars 14 forks source link

Bug Fixes #2084

Closed shyambhongle closed 3 months ago

shyambhongle commented 4 months ago

Bug Fixes on Map

This PR addresses commonly reproducible bugs, including the following:

Zoom-in issues after selecting a project. Delays or unexpected behavior when zooming/viewing the map after selecting a polygon. Data not changing on side panel when hovering over different areas. Data related to sample trees not updating on side panel when clicking on specific sample trees. Issue with the ImageSlider where images were not updating on data change.

Re: When a user clicks on a project after searching for it in the side panel, it takes time to zoom in to the project. Cause: This delay occurs because the pages are rendered on the server, causing a delay only when the cache is expired. Once the cache is present for the page, the CTA behaves as expected.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planet-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 11:52am
planet-webapp-multi-tenancy-setup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 11:52am
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **planet-webapp-temp** | ⬜️ Ignored ([Inspect](https://vercel.com/planetapp/planet-webapp-temp/41g5kHA7mYmzEH7fqfqkXXmUqiaF)) | | | Jun 4, 2024 11:52am |
coderabbitai[bot] commented 4 months ago

Walkthrough

The recent updates focus on refining the functionality and user experience within the project mapping and image handling components. Key changes include enhancing zoom animations, improving map hover interactions, and ensuring robust image processing. These adjustments aim to provide smoother map navigation, better handling of user interactions, and more reliable image displays.

Changes

File Path Change Summary
src/features/projects/components/maps/Project.tsx Adjusted React.useEffect hooks for setting polygon coordinates and zoom behavior based on selected project details.
src/utils/maps/zoomToProjectSite.ts Increased the default duration for the zoom animation from 1200 to 4000 milliseconds.
src/features/projects/components/PlantLocation/... Moved slider component setting inside the loop and added a new variable ask in ImageSlider.tsx.
src/features/projects/components/ProjectsMap.tsx Enhanced onMapHover function with new conditional checks and state updates for handling plant location interactions.
src/features/projects/components/projectDetails/... Added checks for sliderImage and sliderImage.image in ImageSlider.tsx to prevent errors with empty values.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant ProjectsMap
    participant Project
    participant zoomToProjectSite
    participant ImageSlider

    User->>ProjectsMap: Hover over map
    ProjectsMap->>ProjectsMap: onMapHover()
    ProjectsMap->>Project: Update selected plant location
    Project->>zoomToProjectSite: Zoom to location with updated duration
    zoomToProjectSite-->>Project: Zoom completed

    User->>ImageSlider: View project images
    ImageSlider->>ImageSlider: Process images with added checks
    ImageSlider-->>User: Display images

Poem

In the map's embrace, a gentle zoom, Four thousand milliseconds, a smoother bloom. Hover here, hover there, plants reveal, With careful checks, images feel so real. In code we trust, to guide our quest, For projects mapped, we bring our best.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
mariahosfeld commented 4 months ago

While testing directly on my iPhone, zooming does not correctly work when opening a project and after some tries I am experiencing an error, where I just see the empty map, no project details.