Closed sunilsabatp closed 3 weeks ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
planet-webapp-multi-tenancy-setup | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 21, 2024 0:05am |
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Initial observations:
- [ ] When there are fewer results than needed for scroll, the project cards become a little wider, and are no longer aligned with the edges of the controls.
not sure but I don't see this issue on my machine
https://www.loom.com/share/62f70fbe07b6481b9d8c73f6c283d55f?sid=5a54674c-558c-45a2-aac8-7eb909351699
Some key changes in the logic:
@sunilsabatp This should help simplify the context and search logic, as we need to maintain only one list of results instead of 3 (search, topFiltered, allFiltered).
Initial observations:
- [x] The stories no longer work
Stories are displayed now, but the functionality does not work. It should be possible to provide dummy event handlers to switch tabs, open/close search, or select a filter.
- [x] On mobile, the footer doesn't look good, partly because of the background color which is the same as the rest of the screen. Can something be done about this? @gangakhushlani
This still doesn't look good on the smaller mobile screens (around 360px width), as the links are too close to each other. Marking this as an issue to resolve later.
Please check the search functionality. The same query in the current version yields different results than in the new version. Example: Germany has 3 (old) v. 1 (new) results
done
This PR takes care the search, filter, tabs(top, all) view
for (Desktop version)
for (mobile version)
how to test ? visit to the route
/[locale]/prd