Plant-for-the-Planet-org / planet-webapp

The Open Source and Commission Free Application that powers the Trillion Tree Campaign. Visit us to meet reforestation Organizations, individuals and companies who are on a journey to plant, monitor and restore a trillion trees.
https://www.trilliontreecampaign.org
Other
35 stars 14 forks source link

feat: integrate the projectlist controls(tab,search,filter) for large… #2165

Closed sunilsabatp closed 3 weeks ago

sunilsabatp commented 1 month ago

This PR takes care the search, filter, tabs(top, all) view

for (Desktop version) image image

for (mobile version) image image

how to test ? visit to the route/[locale]/prd

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planet-webapp-multi-tenancy-setup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 0:05am
2 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **planet-webapp** | ⬜️ Ignored ([Inspect](https://vercel.com/planetapp/planet-webapp/4oB2ExmY8ccvgWRrd5vL973LJPUq)) | | | Aug 21, 2024 0:05am | | **planet-webapp-temp** | ⬜️ Ignored ([Inspect](https://vercel.com/planetapp/planet-webapp-temp/3qNNHYYE2L8uX7TsyeWCmdNUczHj)) | | | Aug 21, 2024 0:05am |
coderabbitai[bot] commented 1 month ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
mohitb35 commented 1 month ago

Initial observations:

Screenshot 2024-08-08 at 12 17 46 PM

Screenshot 2024-08-08 at 12 19 54 PM

mohitb35 commented 1 month ago

Screenshot 2024-08-08 at 12 35 14 PM

mohitb35 commented 1 month ago

Screenshot 2024-08-08 at 12 41 33 PM

sunilsabatp commented 1 month ago
  • [ ] When there are fewer results than needed for scroll, the project cards become a little wider, and are no longer aligned with the edges of the controls.

Screenshot 2024-08-08 at 12 41 33 PM

not sure but I don't see this issue on my machine image

mohitb35 commented 1 month ago

https://www.loom.com/share/62f70fbe07b6481b9d8c73f6c283d55f?sid=5a54674c-558c-45a2-aac8-7eb909351699

mohitb35 commented 1 month ago

Screenshot 2024-08-09 at 10 13 40 AM

mohitb35 commented 1 month ago

Some key changes in the logic:

  1. When filter or search is applied, do not show the ProjectListTabs - instead, show the result count. e.g. "3 projects found".
  2. Do not show ProjectListTabs in the map view - this should show all projects (after search / filter)
  3. When I come back from a project details screen, clear the filters and search, and show the initial list screen with ProjectListTabs and no filters/search applied.

@sunilsabatp This should help simplify the context and search logic, as we need to maintain only one list of results instead of 3 (search, topFiltered, allFiltered).

mohitb35 commented 1 month ago

Initial observations:

  • [x] The stories no longer work

Screenshot 2024-08-08 at 12 17 46 PM

Stories are displayed now, but the functionality does not work. It should be possible to provide dummy event handlers to switch tabs, open/close search, or select a filter.

mohitb35 commented 1 month ago
  • [x] On mobile, the footer doesn't look good, partly because of the background color which is the same as the rest of the screen. Can something be done about this? @gangakhushlani

Screenshot 2024-08-09 at 10 13 40 AM

This still doesn't look good on the smaller mobile screens (around 360px width), as the links are too close to each other. Marking this as an issue to resolve later.

Screenshot 2024-08-13 at 12 55 43 PM

sunilsabatp commented 3 weeks ago

Please check the search functionality. The same query in the current version yields different results than in the new version. Example: Germany has 3 (old) v. 1 (new) results

done