Projects redesign/project details

sunilsabatp commented 2 months ago

This PR takes care the Project info section which includes

project card
about us
project review
project info
contact details
dive to map (only for mobile)

how to test ? visit ->/locale/prd/[project slug]

[x] project details sidebar (base PR)
- [x] conservation
- [x] restoration - tree
- [x] restoration - m2
[x] unsupported project types (bouquet, funding) redirect to /prd with an error
[x] site functionality
- [x] site selection on map
- [x] dropdown
- [x] zoom into site
[ ] mobile controls
- [ ] explore (to check layout, comment out before release) - carried forward
- [x] sites dropdown
[x] plant location functionality (excluding selection on mobile)
[x] sample plant location functionality (temporary)
[x] show satellite layer by default if no plant locations exist
[x] hide plant locations if satellite view is selected
[ ] static image of site on map (backend?) - carried forward
[x] ~~use existing slide up view (mobile) for plant location details --- cancelled~~
[x] direct url visit with ploc parameter (in review - plant location PR #2211)
[x] direct url visit with site parameter (in review - plant location PR #2211)
[ ] sample plant location/ plant location functionality (swipeable layout) - carried forward
[ ] The back button logic does not seem right, perhaps this can be taken up in a separate PR though. - carried forward
[x] Bug on safari iOS - nav controls are overlapped by browser address bar (in review - this PR)
[ ] Evaluate styles/classes defined for KeyInfo / AdditionalInfo. For example, we have no class defined called infoDetail but this is used in AdditionalInfo, and KeyInfo has code which results in nested singleRowInfoContainer classes. Refactor, and rename where needed. (sep PR) - carried forward
[ ] consolidate translations - carried forward
[x] consolidate utils
[ ] Consolidated UI check - list page - carried forward
- [ ] mobile
- [ ] desktop
[ ] Consolidated UI check - details page - carried forward
- [ ] mobile
- [ ] desktop
[x] Handle projects without sites e.g. agroforestry-to-assist-forest-restoration-in-the-dry-bolivian-andes
- [x] zoomToSingleTreeLocation is already defined
[x] show whole area functionality for sample plant location info
[ ] Code cleanup - carried forward
- [ ] logic to update url params for site/ploc, set selected plant locations, selected sites, selected plant locations etc. exists in many places, make this easier to understand and manage - carried forward
- [ ] Check for references to old project code and separate where needed - carried forward
- [ ] import types explicitly (consistent-type-imports) - carried forward
[ ] I noticed that multiple calls are made to the plantLocations API in mobile devices (map mode) - perhaps this is happening whenever the url gets updated. - carried forward
[ ] Handle case of setting site id to 0 when project has no sites. example (mothersforest project unselecting a plant location; ploc param remains in the url) - carried forward

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp-multi-tenancy-setup	✅ Ready (Inspect)	Visit Preview		Oct 11, 2024 6:00am

2 Skipped Deployments

coderabbitai[bot] commented 2 months ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

mariahosfeld commented 2 months ago

Check again for design consistency. On mobile: Some components are not taking the same width as others, e.g., the image slider and the video are more width.

mohitb35 commented 2 months ago

UI

[x] The trees donated count should be formatted into millions once it crosses a million. Also, only integer value should be seen while displaying the whole count.
e.g. 1. 26,551,073.21 Trees donated ---> 26.5m Trees donated
e.g. 2. 3,392.2 Trees donated --> 3,392 Trees donated
[ ] Font sizes need a review, as mentioned in https://github.com/Plant-for-the-Planet-org/planet-webapp/pull/2183#pullrequestreview-2260731523
[x] The box shadow may need some adjustment, especially when it falls between the scrollbar and the side of the project info container. --> Reduce x, y values to 0, blur to 10px. See if this needs to be updated anywhere else as well.
[x] I noticed that the padding of sections above the image slider is different from the sections below (this is in the design too). Does that need adjustment? The sections above have 16px padding, and the sections below have 24px. @gangakhushlani - keep common 16px
[x] 5. The image slider modal (full screen) functionality is no longer seen. Needs to be added in. @gangakhushlani need a design for the full screen view (rounded corners for the image, close button outside?)
[x] 6. Contact details - the bottom margin below the email results in inconsistent spacing around this section. I'd suggest using gap rather than margin to keep space between all the single contact detail containers.
[x] 7. View Profile - I don't think the link is correct. It should be the tpo profile page.
[x] 8. Project Spending - show integer values (rounded down), but preserve the other formatting.
[x] 9. Back button - take the user to the new list page by default (unless they are coming from another site)
[x] 10. On desktop, the Project Snippet background should be white. Instead it is currently transparent.
[x] 11. The content in the Planting Density and Employees cells can get a little close. Can the min. space be increased a bit?
[x]

mohitb35 commented 2 months ago

Mobile specific UI

Project snippet UI varies from the design. This needs to be refactored for mobile view.

Design

Current UI

mohitb35 commented 2 months ago

Mobile specific UI (contd.)

[x] Also, the project snippet blends into the background as the section background matches with the page background. --> not an issue any more due to the above point, but provide explicit background color to the white portion of the snippet/whole snippet.
[ ] What is to be shown as the background for the Dive into the project section.? @gangakhushlani to check and get back.

mohitb35 commented 1 month ago

@sunilsabatp could you resolve the conflicts and address the functional / UI feedback above?

mohitb35 commented 1 month ago

[x] The price per unit shows up as 0 sometimes because the projects API is being called with a blank currency.

https://app-staging.plant-for-the-planet.org/app/projects/yucatan?_scope=extended&currency=&locale=de