search

Plant-for-the-Planet-org / planet-webapp

The Open Source and Commission Free Application that powers the Trillion Tree Campaign. Visit us to meet reforestation Organizations, individuals and companies who are on a journey to plant, monitor and restore a trillion trees.
https://www.trilliontreecampaign.org
Other
36 stars 15 forks source link

Render plant location layer #2211

Closed sunilsabatp closed 1 month ago

sunilsabatp commented 1 month ago

This PR handles the overall plant location features, which include:

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planet-webapp-multi-tenancy-setup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 10:55am
2 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **planet-webapp** | ⬜️ Ignored ([Inspect](https://vercel.com/planetapp/planet-webapp/8iJmPDjnASvnRHn46ssHGKsf4qE9)) | | | Oct 3, 2024 10:55am | | **planet-webapp-temp** | ⬜️ Ignored ([Inspect](https://vercel.com/planetapp/planet-webapp-temp/Hi92d9Y97QCGSC1cMMDb2viLR5qu)) | | | Oct 3, 2024 10:55am |
coderabbitai[bot] commented 1 month ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
mariahosfeld commented 1 month ago

Please remove markers when zooming into a plantlocation, we only need the little dots image

mariahosfeld commented 1 month ago

Don't know if it is yet covered, but when clicking on a sample tree, I currently do not get any information about it, I just see the information for the parent location.

sunilsabatp commented 1 month ago

Don't know if it is yet covered, but when clicking on a sample tree, I currently do not get any information about it, I just see the information for the parent location.

I have created separate branch for to cover sample plant location functionality

mohitb35 commented 1 month ago

UI

mohitb35 commented 1 month ago

Not sure this will be resolved in this PR, but there are frequent crashes related to react-insta-stories,

Often, we see this when the user comes back to the screen after keeping the tab in the background for a while.

sunilsabatp commented 1 month ago

Not sure this will be resolved in this PR, but there are frequent crashes related to react-insta-stories,

Often, we see this when the user comes back to the screen after keeping the tab in the background for a while.

I have fixed this issue in the sample plant location PR

sunilsabatp commented 1 month ago

UI

  • [x] Background for the PlantLocationInfo section should be white in desktop - have confirmed with Ganga
  • [x] Modal view for image slider is pending.
  • [x] In mobile view, after going to the map mode, selecting a plant location, and coming back to the list mode, I still see the plant location data. We should probably clear the plant location (selectedPl, hoveredPl) data when coming back to the list mode

The first point I have covered in the sample plant location PR

mohitb35 commented 1 month ago

The functionality to select the first site and zoom into it when the page is first loaded is no longer working, if I go to the project details page directly.

e.g. https://planet-webapp-multi-tenancy-setup-git-projects-58fa28-planetapp.vercel.app/en/prd/plant-for-ghana

mohitb35 commented 1 month ago

UI

  • [x] In mobile view, after going to the map mode, selecting a plant location, and coming back to the list mode, I still see the plant location data. We should probably clear the plant location (selectedPl, hoveredPl) data when coming back to the list mode

While the plant location info is not visible any more when I come back to the list mode, the selectedPlantLocation still remains in context. I feel that going to the list mode should reset some parts of the state - let's discuss this @mariahosfeld @sunilsabatp

If the user has directly gone to the project details page with site or ploc param in the url on a mobile device ; Do we show list or map view ?