Plant-for-the-Planet-org / planet-webapp

The Open Source and Commission Free Application that powers the Trillion Tree Campaign. Visit us to meet reforestation Organizations, individuals and companies who are on a journey to plant, monitor and restore a trillion trees.
https://www.trilliontreecampaign.org
Other
37 stars 15 forks source link

Fixes unsupported currencies in country selector #2223

Closed mohitb35 closed 2 months ago

mohitb35 commented 2 months ago

This pull request fixes an issue where countries with unsupported currencies were still being displayed in the country selector.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
planet-webapp-multi-tenancy-setup βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 11, 2024 6:44am
2 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **planet-webapp** | ⬜️ Ignored ([Inspect](https://vercel.com/planetapp/planet-webapp/HHEDAuZvwCuingHd6bSdJ6HwmiQA)) | | | Sep 11, 2024 6:44am | | **planet-webapp-temp** | ⬜️ Ignored ([Inspect](https://vercel.com/planetapp/planet-webapp-temp/Cu6QdFfxYiKoENYiN3hgaaNJw54L)) | | | Sep 11, 2024 6:44am |
coderabbitai[bot] commented 2 months ago

Walkthrough

This pull request introduces a CurrencyProvider to the PlanetWeb application, enhancing the context management for currency data. The CurrencyProvider is integrated into the component hierarchy, allowing child components to access currency-related information. Additionally, a new CurrencyContext is created to manage supported currencies, and existing components are updated to utilize this context. The sortCountriesByTranslation function is modified to filter countries based on their associated currency codes, improving the application's handling of country and currency relationships.

Changes

Files Change Summary
pages/_app.tsx Added CurrencyProvider to the component hierarchy, modifying context structure for child components.
src/features/common/Layout/CurrencyContext.tsx Introduced CurrencyContext and CurrencyProvider, including state management and a custom hook useCurrency.
src/features/common/Layout/Footer/SelectLanguageAndCountry.tsx Incorporated useCurrency to enhance country sorting logic with currency support.
src/utils/countryCurrency/countryUtils.js Modified sortCountriesByTranslation to include a new parameter for supported currency codes and updated filtering logic.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant CurrencyProvider
    participant ChildComponent
    participant CountryUtils

    App->>CurrencyProvider: Initialize
    CurrencyProvider->>ChildComponent: Provide currency context
    ChildComponent->>CurrencyProvider: Request supported currencies
    CurrencyProvider-->>ChildComponent: Return supported currencies
    ChildComponent->>CountryUtils: Sort countries with currencies
    CountryUtils->>ChildComponent: Return sorted countries

Poem

πŸ‡ In a world of coins and notes,
A new provider proudly floats.
With currencies now in sight,
Sorting countries feels just right.
Hops of joy, let’s celebrate,
For every change, we elevate! πŸŽ‰


Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 91406322110cf18079ff1e88bf30cb66fb30a731 and 58b4e47e4358ad23620375ef5d428d98b24c4829.
Files selected for processing (4) * pages/_app.tsx (2 hunks) * src/features/common/Layout/CurrencyContext.tsx (1 hunks) * src/features/common/Layout/Footer/SelectLanguageAndCountry.tsx (2 hunks) * src/utils/countryCurrency/countryUtils.js (1 hunks)
Additional comments not posted (4)
src/utils/countryCurrency/countryUtils.js (1)
`48-69`: **LGTM!** The changes to the `sortCountriesByTranslation` function are approved. The addition of the `supportedCurrencyCodes` parameter and the filtering logic improves the functionality of the function by allowing it to filter countries based on their currency codes.
src/features/common/Layout/Footer/SelectLanguageAndCountry.tsx (1)
`97-105`: **LGTM!** The changes to the `MapCountry` function are approved. The addition of the `supportedCurrencies` variable and passing it as an argument to the `sortCountriesByTranslation` function improves the functionality of the component by incorporating currency support into the country sorting logic.
pages/_app.tsx (2)
`37-37`: **LGTM!** The import statement for `CurrencyProvider` is correctly added. --- `219-291`: **LGTM!** The `CurrencyProvider` is correctly integrated into the component hierarchy, and its positioning before the `TenantProvider` is appropriate. The rest of the component hierarchy remains unchanged.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.