Post Launch feedback for projects facelift

mohitb35 commented 2 weeks ago

Improve date formatting by adding string cleanup and zero-padding.
Simplify conditional rendering in the KeyInfo component for better readability and maintainability.
Correct minor alignment issues in the site dropdown and explore buttons.
Allow project details to overflow till bottom of page
Potential fix to make sure map resizes as per container dimensions
Minor adjustment to position of zoom buttons on mobile (android/iOS) to avoid hiding behind footer
Prevent map re-centering when the project filter/search result set is >30 projects long
italicises scientific name in sample plant location details
formats site area in site dropdown as per locale

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp-multi-tenancy-setup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 11, 2024 9:31am

2 Skipped Deployments

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The pull request introduces several changes across multiple files, including updates to styling in SCSS files, modifications to React components for improved state management, and enhancements to a date formatting utility. Key changes involve the transition from prop-based state management to context-based management for map-related components, as well as adjustments to layout properties and conditional rendering logic. Additionally, the .gitignore file has been updated to exclude specific certificate files.

Changes

File	Change Summary
`.gitignore`	Added entries for `certificates/localhost-key.pem` and `certificates/localhost.pem`.
`src/features/common/Layout/ProjectsLayout/ProjectsLayout.module.scss`	Updated `.mapFeatureExplorerOverlay` class to change `top` property from `calc($layoutPaddingTop + 8px)` to `calc($layoutPaddingTop + 10px)`.
`src/features/projectsV2/ProjectDetails/ProjectDetails.module.scss`	Updated `.projectDetailsContainer` height from `100%` to `calc(100% + 30px)` and added `padding-bottom: 30px`.
`src/features/projectsV2/ProjectDetails/components/KeyInfo.tsx`	Restructured conditional rendering logic using new boolean flags for displaying project information, removing the `addZeroToDate` function.
`src/features/projectsV2/ProjectsMap/MultipleProjectsView.tsx`	Removed `setViewState` prop, added `useProjectsMap` import, and updated view state management to use `handleViewStateChange`.
`src/features/projectsV2/ProjectsMap/ProjectSiteDropDown/SiteDropdown.module.scss`	Introduced new variables `$layoutPaddingTop` and `$layoutPaddingSide` for dynamic positioning of `.dropdownButton`.
`src/features/projectsV2/ProjectsMap/ProjectsMap.module.scss`	Updated `.mapContainer` to include `position: relative` and `overflow: hidden`, adjusted bottom positioning for `.android` and `.ios` classes.
`src/features/projectsV2/ProjectsMap/SingleProjectView.tsx`	Renamed `setViewState` to `handleViewStateChange` in the `SingleProjectView` component.
`src/features/projectsV2/ProjectsMap/index.tsx`	Added `ViewStateChangeEvent` import, updated view state management to use `handleViewStateChange`, and integrated centering logic into a debounced effect.
`src/features/projectsV2/ProjectsMapContext.tsx`	Introduced `ExtendedViewState` interface, updated `DEFAULT_VIEW_STATE` to include width and height, and replaced `setViewState` with `handleViewStateChange`.
`src/utils/countryCurrency/getFormattedDate.ts`	Modified `formatDate` function for improved date handling and error management.
`src/utils/mapsV2/zoomToLocation.tsx`	Updated `zoomToLocation` function to replace `setViewState` with `handleViewStateChange`.
`src/utils/mapsV2/zoomToPolygonPlantLocation.tsx`	Modified `zoomToPolygonPlantLocation` function to use `handleViewStateChange` instead of `setViewState`.
`src/utils/mapsV2/zoomToProjectSite.ts`	Updated `zoomInToProjectSite` function to replace `setViewState` with `handleViewStateChange`, streamlined type handling.
`src/utils/projectV2.ts`	Added new function `areMapCoordsEqual` for comparing map coordinates, and refined `getLocalizedPath` function for better path handling.
`src/features/projectsV2/ProjectDetails/components/microComponents/PlantInfoCard.tsx`	Added a new CSS class to the `scientificName` div and updated rendering logic for the `tag` property.
`src/features/projectsV2/ProjectDetails/styles/PlantLocationInfo.module.scss`	Added a nested style rule for `.scientificName .data` to set `font-style` to `italic`.
`src/features/projectsV2/ProjectsMap/ProjectSiteDropDown/ProjectSiteList.tsx`	Enhanced site area formatting by incorporating locale-specific formatting using `getFormattedRoundedNumber`.
`src/features/projectsV2/ProjectsMap/ProjectSiteDropDown/index.tsx`	Integrated locale-based formatting for the site area display in the dropdown.
`src/features/projectsV2/ProjectDetails/components/microComponents/SpeciesPlanted.tsx`	Updated to format `treeCount` using `getFormattedNumber` based on current locale.

Possibly related PRs

#2213: Modifications to a CSS class name in ProjectsLayout.module.scss relevant to layout adjustments.
#2246: Updates to the tooltip component that may relate to overall user interface adjustments.
#2273: Updates to the PlantLocationDetails component involving layout considerations.

Suggested labels

MyForest 2.0, PR: unreviewed

Suggested reviewers

sunilsabatp

🐇 In the forest where changes bloom,
New styles and logic make room.
With padding and heights, we dance and play,
Enhancing our layout in a joyful way!
From maps to dates, all in a row,
Let's hop along and watch our project grow! 🌱

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

Plant-for-the-Planet-org / planet-webapp