Plant-for-the-Planet-org / treemapper

TreeMapper extends the Plant-for-the-Planet Platform and allows on site data registration for restoration initiatives.
https://treemapper.app
Other
26 stars 2 forks source link

Bugfixes-release(1.0.9) #744

Closed shyambhongle closed 3 weeks ago

shyambhongle commented 7 months ago

Fixes #

Changes in this pull request:

@mayankkumawat

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

norbertschuler commented 7 months ago

Still a lot of (old) bugs in the app, e.g. this crash at updateSpecieAndMeasurements() because of an empty species state resulting from inventoryData.specieDiameter not being null at https://github.com/Plant-for-the-Planet-org/treemapper/blob/84f2195a3e3ccbdcdc4f2d26c01885bd4f54b775/app/components/SelectSpecies/AddMeasurements.tsx#L63 as if you try to register a single tree using the new navigation item in the popup menu from the map instead the register tree button in the inventory list:

Simulator Screenshot - iPhone 15 Pro - 2024-02-22 at 09 39 57Simulator Screenshot - iPhone 15 Pro - 2024-02-22 at 09 39 32Simulator Screenshot - iPhone 15 Pro - 2024-02-22 at 09 39 39

norbertschuler commented 7 months ago

Another crash I got trying to hit the remeasure button for an already uploaded registered tree in my profile as route.params was undefined at https://github.com/Plant-for-the-Planet-org/treemapper/blob/84f2195a3e3ccbdcdc4f2d26c01885bd4f54b775/app/components/RegisterSingleTree/SingleTreeOverview.tsx#L1125 - not sure why this value is unset viewing some uploaded item in the inventory:

Simulator Screenshot - iPhone 15 Pro - 2024-02-22 at 09 51 26Simulator Screenshot - iPhone 15 Pro - 2024-02-22 at 09 51 06Simulator Screenshot - iPhone 15 Pro - 2024-02-22 at 09 51 01

shyambhongle commented 7 months ago

Hi, Thank you for informing me about these additional issues. I'm already addressing the problems noted in 'Notion' from our last test flight. I will include these two new issues in my current workflow. I plan to raise PR for the fixes I'm currently working on. Additionally, I will provide detailed findings on certain bugs I've debugged but have not yet resolved. My hesitation stems from a need for more context to understand the potential implications of these fixes like the one you mentioned where we are not sending value to 'SingleTreeOverview'.

norbertschuler commented 7 months ago

If you login having a TPO with a project, then logout again and try to login again, the app crashes at this place:

Simulator Screenshot - iPhone 15 Pro - 2024-02-22 at 10 01 44

norbertschuler commented 7 months ago

My hesitation stems from a need for more context to understand the potential implications of these fixes like the one you mentioned where we are not sending value to 'SingleTreeOverview'.

Unfortunately I am not the author of this code, so I cannot give you any software architecture overview of this project.