Closed shyambhongle closed 3 weeks ago
Issues
0 New issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Still a lot of (old) bugs in the app, e.g. this crash at updateSpecieAndMeasurements()
because of an empty species state resulting from inventoryData.specieDiameter
not being null at https://github.com/Plant-for-the-Planet-org/treemapper/blob/84f2195a3e3ccbdcdc4f2d26c01885bd4f54b775/app/components/SelectSpecies/AddMeasurements.tsx#L63 as if you try to register a single tree using the new navigation item in the popup menu from the map instead the register tree button in the inventory list:
Another crash I got trying to hit the remeasure button for an already uploaded registered tree in my profile as route.params
was undefined at https://github.com/Plant-for-the-Planet-org/treemapper/blob/84f2195a3e3ccbdcdc4f2d26c01885bd4f54b775/app/components/RegisterSingleTree/SingleTreeOverview.tsx#L1125 - not sure why this value is unset viewing some uploaded item in the inventory:
Hi, Thank you for informing me about these additional issues. I'm already addressing the problems noted in 'Notion' from our last test flight. I will include these two new issues in my current workflow. I plan to raise PR for the fixes I'm currently working on. Additionally, I will provide detailed findings on certain bugs I've debugged but have not yet resolved. My hesitation stems from a need for more context to understand the potential implications of these fixes like the one you mentioned where we are not sending value to 'SingleTreeOverview'.
If you login having a TPO with a project, then logout again and try to login again, the app crashes at this place:
My hesitation stems from a need for more context to understand the potential implications of these fixes like the one you mentioned where we are not sending value to 'SingleTreeOverview'.
Unfortunately I am not the author of this code, so I cannot give you any software architecture overview of this project.
Fixes #
Changes in this pull request:
@mayankkumawat