search

PlantPhenoOntology / ppo

An ontology for describing the phenology of individual plants and populations of plants, and for integrating plant phenological data across sources and scales.
16 stars 8 forks source link

Add comment to senescent leaf stage #33

Closed ramonawalls closed 7 years ago

ramonawalls commented 7 years ago

http://purl.obolibrary.org/obo/PPO_0000013

Add comment:

Leaf color is often used as an indicator of the senescent leaf stage, but note that leaf coloration due to photoprotection (http://amigo.geneontology.org/amigo/term/GO:0010117) is not an indicator of senescence.

ramonawalls commented 7 years ago

@stuckyb Is there a way to include a term from GO that is not imported into PPO in the comment? I want to say in the comment "Leaf color is often used as an indicator of the senescent leaf stage, but note that leaf coloration due to {photoprotection} is not an indicator of senescence" but since photoprotection is not imported into PPO, not sure what will happen. Maybe we should just import the class for reference.

stuckyb commented 7 years ago

Comment references will only work for terms in the ontology or its imports closure (for now, anyway). So, we'd need to add photoprotection to the list of terms imported from the GO. And I agree, might not be a bad idea to import it anyway.

On 06/18/2017 04:46 PM, Ramona Walls wrote:

@stuckyb https://github.com/stuckyb Is there a way to include a term from GO that is not imported into PPO in the comment? I want to say in the comment "Leaf color is often used as an indicator of the senescent leaf stage, but note that leaf coloration due to {photoprotection} is not an indicator of senescence" but since photoprotection is not imported into PPO, not sure what will happen. Maybe we should just import the class for reference.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PlantPhenoOntology/ppo/issues/33#issuecomment-309301820, or mute the thread https://github.com/notifications/unsubscribe-auth/ADKD7wM84DFk07ycFWGzo7TYwibW8BgCks5sFYyLgaJpZM4N047f.

ramonawalls commented 7 years ago

Okay, thanks. I'll add it and rebuild the imports.

ramonawalls commented 7 years ago

go_ppo_imports.csv has been edited but new import file has not been built yet.