PlantPhenoOntology / ppo

An ontology for describing the phenology of individual plants and populations of plants, and for integrating plant phenological data across sources and scales.
16 stars 8 forks source link

Check definition of falling leaf phenological stage #42

Closed ramonawalls closed 7 years ago

ramonawalls commented 7 years ago

From Ellen: The definition of this specifies that the plant "has abscised at least one {vascular leaf}... but has not yet abscised all its leaves." I could be wrong but I'm thinking this last clause might be problematic. For our "Falling leaves" phenophases, observers could report "yes" to the phenophase after all leaves have abscised. The criteria is that leaves have "recently" fallen from the plant, so the first time they see the tree with no leaves left, I would expect them to report "yes" for falling leaves.

ramonawalls commented 7 years ago

Presumably this last phrase was added because it doesn't make sense to say that a plant is in the "falling leaf stage" if all of the leaves have fallen already and technically no more leaves can be falling from it. For practical purposes, I understand that you would want to score plants as in this stage when all of the leaves have just fallen, but technically, that plant is not losing leaves.

Perhaps a better solution is to leave the definition as is, and add a comment saying that there might be some error in the date of the scoring, because observers may not see the process until just after it has happened.

robgur commented 7 years ago

+1

On Fri, Jun 16, 2017 at 12:02 AM, Ramona Walls notifications@github.com wrote:

Presumably this last phrase was added because it doesn't make sense to say that a plant is in the "falling leaf stage" if all of the leaves have fallen already and technically no more leaves can be falling from it. For practical purposes, I understand that you would want to score plants as in this stage when all of the leaves have just fallen, but technically, that plant is not losing leaves.

Perhaps a better solution is to leave the definition as is, and add a comment saying that there might be some error in the date of the scoring, because observers may not see the process until just after it has happened.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PlantPhenoOntology/PPO/issues/42#issuecomment-308927278, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcc7Ewu2Dhln6s2dwpfLgd2ORTiFdVAks5sEf5KgaJpZM4N7_1E .

edenny commented 7 years ago

Yup, sounds good!

ramonawalls commented 7 years ago

New comment: Some error may be associated with dates this stage, because observers may not see the plant until just after all leaves have fallen, but they still score it as "falling leaves present".