search

PlantPhenoOntology / ppo

An ontology for describing the phenology of individual plants and populations of plants, and for integrating plant phenological data across sources and scales.
16 stars 8 forks source link

leaf stage names #45

Closed stuckyb closed 7 years ago

stuckyb commented 7 years ago

Most of our leaf-related phenological stage names follow the pattern "adjective leaf phenological stage". For consistency, I propose we change "leaf expansion phenological stage" to "expanding leaf phenological stage".

A second inconsistency is in the names "non-senescing leaf phenological stage" and "senescent leaf phenological stage". These classes are mutually exclusive, so it would be nice if the names used terminology consistently. E.g., use either "senescent" or "senescing" for both names.

robgur commented 7 years ago

+1

On Jun 21, 2017 7:40 AM, "stuckyb" notifications@github.com wrote:

Most of our leaf-related phenological stage names follow the pattern " adjective leaf phenological stage". For consistency, I propose we change "leaf expansion phenological stage" to "expanding leaf phenological stage".

A second inconsistency is in the names "non-senescing leaf phenological stage" and "senescent leaf phenological stage". These classes are mutually exclusive, so it would be nice if the names used terminology consistently. E.g., use either "senescent" or "senescing" for both names.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PlantPhenoOntology/ppo/issues/45, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcc7JSBkSRewM-o_qm_x-oOevgN4nQzks5sGR1GgaJpZM4OA-f8 .

stuckyb commented 7 years ago

Anyone have thoughts on "senescent" vs "senescing"? I think I like "senescing" better because it reflects that senescing is a process and not just an end state (I suspect that fits better with what observers actually record). Ramona and/or Ellen should weigh in on this, though.

On 06/21/2017 09:50 AM, Rob wrote:

+1

On Jun 21, 2017 7:40 AM, "stuckyb" notifications@github.com wrote:

Most of our leaf-related phenological stage names follow the pattern " adjective leaf phenological stage". For consistency, I propose we change "leaf expansion phenological stage" to "expanding leaf phenological stage".

A second inconsistency is in the names "non-senescing leaf phenological stage" and "senescent leaf phenological stage". These classes are mutually exclusive, so it would be nice if the names used terminology consistently. E.g., use either "senescent" or "senescing" for both names.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PlantPhenoOntology/ppo/issues/45, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcc7JSBkSRewM-o_qm_x-oOevgN4nQzks5sGR1GgaJpZM4OA-f8 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PlantPhenoOntology/ppo/issues/45#issuecomment-310084522, or mute the thread https://github.com/notifications/unsubscribe-auth/ADKD77uZk_nkOn1pCHwXiUwk0v9t4dbRks5sGR-agaJpZM4OA-f8.

ramonawalls commented 7 years ago

Agree with the suggestions. I think senescing is better than senescent, because that is how we define it.

stuckyb commented 7 years ago

Fixed with commit c79c90e.