search

PlantPhenoOntology / ppo

An ontology for describing the phenology of individual plants and populations of plants, and for integrating plant phenological data across sources and scales.
16 stars 8 forks source link

leaf trait/stage name consistency #46

Closed stuckyb closed 7 years ago

stuckyb commented 7 years ago

Another naming consistency issue. We have 'vascular leaf phenological stage', but the corresponding trait cluster is 'leaf presence', 'leaves absent', 'leaves present'. We should probably use consistent naming for clarity. Either use "vascular" in all four or don't use it in any.

robgur commented 7 years ago

I lean towards making explicit the term "vascular" for all.

On Wed, Jun 21, 2017 at 8:16 AM, stuckyb notifications@github.com wrote:

Another naming consistency issue. We have 'vascular leaf phenological stage', but the corresponding trait cluster is 'leaf presence', 'leaves absent', 'leaves present'. We should probably use consistent naming for clarity. Either use "vascular" in all four or don't use it in any.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PlantPhenoOntology/ppo/issues/46, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcc7FN8SxfjLd8m_bK5HWNB7Onlhwckks5sGSXFgaJpZM4OBBtM .

ramonawalls commented 7 years ago

Using vascular in all would be consistent with PO. Longer labels, but I think we can live with that.

stuckyb commented 7 years ago

I made these changes with commit c79c90e, but now I wonder if the term we want to use is "true leaf", not "vascular leaf". "vascular leaf" includes cotyledons, and our stages and traits concern vascular leaves that are not cotyledons; i.e., true leaves.

robgur commented 7 years ago

Lets do "true leaf" -- I am convinced. -r

On Wed, Jun 21, 2017 at 3:02 PM, stuckyb notifications@github.com wrote:

I made these changes with commit c79c90e https://github.com/PlantPhenoOntology/ppo/commit/c79c90eabb23d63ce3eba2dc650c21545bf6a035, but now I wonder if the term we want to use is "true leaf", not "vascular leaf". "vascular leaf" includes cotyledons, and our stages and traits concern vascular leaves that are not cotyledons; i.e., true leaves.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PlantPhenoOntology/ppo/issues/46#issuecomment-310204485, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcc7BhmmvyAnRM8HPCxYii8z8ULisB_ks5sGYUAgaJpZM4OBBtM .

ramonawalls commented 7 years ago

I'm okay with using true leaf, but Brian, as I am in the midst of editing, so please don't make any changes for the next few hours.

Also, if you changed all these labels, does that mean that all the definitions that use them have to change? I'm inclined to leave things as they are until we do the data ingest.

stuckyb commented 7 years ago

Okay, sounds good -- will switch to 'true leaf' at some point when Ramona's not making other changes. Yes, if labels change, all the definitions that use them need to change, too, but OntoPilot will make sure that there are no "orphan" labels used anywhere.

On 06/21/2017 07:07 PM, Ramona Walls wrote:

I'm okay with using true leaf, but Brian, as I am in the midst of editing, so please don't make any changes for the next few hours.

Also, if you changed all these labels, does that mean that all the definitions that use them have to change? I'm inclined to leave things as they are until we do the data ingest.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PlantPhenoOntology/ppo/issues/46#issuecomment-310229788, or mute the thread https://github.com/notifications/unsubscribe-auth/ADKD77cZCMqaM6lIeFq2goRFQkDYIke1ks5sGaI0gaJpZM4OBBtM.

ramonawalls commented 7 years ago

@stuckyb - I will not make any edits before Monday, so hack away at the labels!

stuckyb commented 7 years ago

Changed to "true leaf/leaves" with commit 52d618e.