Closed stuckyb closed 7 years ago
+1 for deleting the "fruit ripe stage" if it is not used elsewhere.
@stuckyb, your proposed changes to the definition of ripe fruit make perfect sense. I also agree that we should get rid of fruit ripe stage. Since we have not used it or released it yet, we can simply delete it, without using deprecation.
Fixed with 5ca2949.
The definition of 'ripe fruit' is currently
This is just a copy (more or less) of the definition of 'fruit ripe stage'. Copying definitions is not a good design because it makes it too easy for definitions to get out of sync. I propose changing this to
Alternatively, we could just delete the class 'fruit ripe stage' and only have 'ripe fruit' for now, since it is the only class that is actually used by the rest of the PPO.