search

PlantPhenoOntology / ppo

An ontology for describing the phenology of individual plants and populations of plants, and for integrating plant phenological data across sources and scales.
16 stars 8 forks source link

fruit initiation stage #75

Open edenny opened 9 months ago

edenny commented 9 months ago

The Env Study Centre dataset from India includes a phase for fruit bud/fruit initiation. He described it to me as "just after the fall of petals small fruit bud appears after the falling of flower, immature fruit means not yet ripened the stage between fruit bud and ripened fruit". It is followed by an immature fruit stage.

Should we add something for this?

ClaudHGE commented 9 months ago

Hi @edenny I have noticed that as well. I'm currently editing a branch to submit a pull request for that issue.

ramonawalls commented 8 months ago

@ClaudHGE, could you please add your justification for including a new class here?

ClaudHGE commented 8 months ago

🚧 working on it!

edenny commented 7 months ago

This sounds reasonable to me and works for the datasets I have seen so far.

One point of clarification though @ClaudHGE ....where you write:

"Now, when a fruit is in the 'fruit unripe stage', an occurrent entity, what we can actually observe is the 'unripe fruit' (PPO:0001045), a continuant entity, and the respective phenological trait would be ‘ripe fruit presence’ (PPO:0002047) and we could either annotate ‘ripe fruits present’ (PPO:0002345) or 1 'ripe fruit'. (Please correct me if I am wrong). "

I think you meant to say the respective phenological trait would be ‘unripe fruit presence’ , correct?

ClaudHGE commented 7 months ago

You are absolutely right! I've edited the comment.