PlantPhenoOntology / ppo

An ontology for describing the phenology of individual plants and populations of plants, and for integrating plant phenological data across sources and scales.
16 stars 8 forks source link

Use default labels for classes generated by patterns #83

Closed ramonawalls closed 1 week ago

ramonawalls commented 2 months ago

When we were using OntoPilot to build the ontology, we created custom labels for some of the classes that were built using patterns. For example, PPO_0002346 was labeled "cones present" instead of "strobilus present".

I fear that using a custom label with patterns may lead to confusing. Nonetheless, the custom labels are important for our users. For this issue, I will switch to default labels based on the parent rdfs:label. I'll create a separate issue for adding alternative labels.

See issue #84 .

ramonawalls commented 2 months ago

@edenny @jdeck88 and I discussed and agreed on this decision during one of our recent calls.

ramonawalls commented 1 month ago

Another change is to the definition of plant structure presence traits. For example, the of new shoot system presence will change from

A {plant phenological trait} that is measured by the number of new shoot systems {$new shoot system} on a {whole plant}.

To:

A plant structure presence that represents whether a new shoot system is present or absent on a whole plant.

The comment will remain for clarity: The number can be 0 or more.

ramonawalls commented 1 week ago

Done in pattern files