PlantPhenoOntology / ppo

An ontology for describing the phenology of individual plants and populations of plants, and for integrating plant phenological data across sources and scales.
16 stars 7 forks source link

fix and maybe deprecate phenology observing process #96

Closed ramonawalls closed 4 days ago

ramonawalls commented 4 days ago

phenology observing process (PPO:0007004) has an EQ axiom that doesn't work and specifies:

I think the problem is saying that it has some output that is a process (is quality datum). I changed it to:

which makes more sense to me. However, it still does not work. The syntax validator in ROBOT will not accept clauses like:

even though they are in the current ontology release AND they work fine in DOSDP patterns.

ramonawalls commented 4 days ago

Do we really need this relationship? I don't think we need to do any reasoning over the axiom, so it may be better to just use BCO:observing process, or even OBI:planned process.

@jdeck88 are you aware of a step in the pipeline that uses this axiom?

ramonawalls commented 4 days ago

I have struggled with this long enough. I'll submit an issue in the ROBOT repo. For now, I will change this axiom to

which should not mess up anything in our reasoning, since we aren't doing any reasoning over the observing processes now that we have removed GCIs from the trait present and absent classes.

ramonawalls commented 4 days ago

See also #89