PlantSimulationLab / Helios

The Helios simulation system is a versatile modeling framework that handles tasks such as managing geometry and associated data structures through a C++ API. Plug-ins build off of the Helios core engine, and access the geometry and data via the Helios context. The sytem comes with a visualization plug-in that can produce stunning renderings of model geometry and data with relatively little effort.
http://baileylab.ucdavis.edu/software/helios
GNU General Public License v2.0
61 stars 27 forks source link

Fix Creating Directories on Windows for Synthetic Annotation #45

Closed smbanx closed 1 month ago

smbanx commented 1 month ago

The command mkdir -p <DIRECTORY> is not a valid terminal command on Windows, leading to errors when synthetic annotation is performed. With this change, I replace the mkdir -p <DIRECTORY> system calls with std::filesystem::create_directory(<DIRECTORY>) function calls. The Filesystem library is available as of C++17, and the function create_directory() handles the creation of nested directories in the same way as mkdir -p.

With this simple change, synthetic annotation should work properly on Windows, Linux, and MacOS.

bnbailey-psl commented 1 month ago

Merged in Helios v1.3.20.