Planteome / CO_321-wheat-traits

Wheat trait ontology
https://cropontology.org/term/CO_321:ROOT
5 stars 2 forks source link

Encoding issue with non ASCII characters #13

Open cpommier opened 4 years ago

cpommier commented 4 years ago

Example: current Wheat_td.csv Trait description is missing ü in Müller toward the end:

Septoria nodorum blotch incidence in the plants caused by the agent Stagonospora nodorum (syn. Septoria glume blotch) (Phaeosphaeria nodorum (E. M ller) Hedjaroude (syn. Stagonospora nodorum).

Should be:

Septoria nodorum blotch incidence in the plants caused by the agent Stagonospora nodorum (syn. Septoria glume blotch) (Phaeosphaeria nodorum (E. Müller) Hedjaroude (syn. Stagonospora nodorum).

I have created a dedicated branch. We are working on it and will let you know as soon as it seems complete by assigning it to @marieALaporte if that's fine with you. Let us know if you want to discuss this.

cpommier commented 4 years ago

See https://github.com/Planteome/ibp-wheat-traits/tree/fix/char_encoding%2313

cooperl09 commented 4 years ago

It is correct in the obo file.
Also displays correctly on our browser: http://dev.planteome.org/amigo/term/CO_321:0000917 (set text encoding to Western) Capitalization does need to be corrected, though.

cpommier commented 4 years ago

Hi We have two masters here the obo and the csv. The obo is the master for planteome, and the csv for other systems. The obo might be ok but the csv is broken, hence need fixing. There are some synonyms and some variable name that have encoding problems too, and that's an integration problem that needs solving quickly :)

cpommier commented 4 years ago

Ok it seems better now. I propose two merge request: