search

Planteome / CO_321-wheat-traits

Wheat trait ontology
https://cropontology.org/term/CO_321:ROOT
5 stars 2 forks source link

T3 Modifications #28

Open dwaring87 opened 2 years ago

dwaring87 commented 2 years ago

scale categories are sorted by key in the Trait Dictionary (categories are in a random order in the existing TD) add new variables derived from drone imagery from Texas UASHub add additional agronomic and disease traits requested by breeders

cpommier commented 1 year ago

Hi @dwaring87 , I just merged a rather big change that has been waiting for some time, see #17 . One important change to take into account is the ordering by variableID column in the CSV. I hope it will not be too troubelsome to reapply your changes. Sorry for the delay in merging and the possible inconvenient it triggered.

cpommier commented 1 year ago

Maybe better to reapply your changes by hand from a fresh pull of the master branch rather than trying to resolve conflicts using meld or any git diftool ?

dwaring87 commented 1 year ago

@cpommier I think this new commit has all of the changes that were in the original PR from last year. We generate the trait dictionary file programtically, but it's difficult to compare to the planteome version since the scale categories are in a random order. If those could be sorted numerically, it would make comparisons a lot easier.

dwaring87 commented 1 year ago

@cpommier Any update on this PR? I'd like to not have it sit for too long again and become out of date with the master branch.