Closed bellerbrock closed 5 years ago
@bellerbrock part of the changes in this PR are also in the other PR... not sure how it is going to work ... Should you cancel the other PR and have @nmenda and @vhualla review this one instead?
Ah, I see what you're saying @marieALaporte. I think I accidentally created this branch while checked out on the other branch. I'll merge this one and delete the other.
@cooperl09 I think measurements of the traits are also taken on seedling plants and small pots in the greenhouse. But I can get more details and refine the definition if these measurements are restricted to beds.
@bellerbrock I agree with @cooperl09 check if the fact that the plants are in beds (Vs pots or anything else) makes the measurement unique. If not, then it should be added as a phenotypeprop If having the plants in beds makes the phenotypes uncomparable with similar measurements in pots, then it would make sense to have this as part of the trait name and definition
Ok, so these traits are used elsewhere. Should be good to merge if someone could please add their review.
@nmenda @marieALaporte @vhualla The branch is ready to merge now if someone could please add their review!
Description
Edits existing traits to add missing methods and scales and fix identified errors
Checklist