search

PlasmaControl / DESC

Stellarator Equilibrium and Optimization Suite
MIT License
98 stars 26 forks source link

Check TODO in least_squares #1395

Closed dpanici closed 6 days ago

dpanici commented 1 week ago

https://github.com/PlasmaControl/DESC/blob/95612fa625bd5ba939569004c767ed02594586f0/desc/optimize/least_squares.py#L347

I am pretty sure this can be moves to the outer loop without issue

f0uriest commented 6 days ago

No this should stay where it is, there are edge cases where otherwise it will loop indefinitely.