search

PlasmaControl / PyRCN

A Python 3 framework for Reservoir Computing with a scikit-learn-compatible API.
BSD 3-Clause "New" or "Revised" License
89 stars 19 forks source link

BaseComposition_ for a better parameter management #19

Closed renierts closed 3 years ago

renierts commented 3 years ago

ESNs and ELMs should directly obtain their hyper parameters instead of indirectly using "input_to_node__input_scaling" etc.

https://github.com/scikit-learn/scikit-learn/blob/95119c13af77c76e150b753485c662b7c52a41a2/sklearn/utils/metaestimators.py#L19

renierts commented 3 years ago

This is not necessary and now solved differently: kwargs for the estimators are working with the last commit.