Closed webmaster128 closed 6 years ago
Did you find the subsec_nanos
to be necessary? Either way, I'd prefer to only call .elapsed()
once. Rustfmt doesn't do this automatically since it's a macro, but I usually put a trailing comma for a multiline eprintln!
invocation. Other than those small things, LGTM. Thanks!
Thanks for feedback, will update
Did you find the subsec_nanos to be necessary?
I use it because second resolution was not sufficient. I got values jumping up and down like crazy in the first seconds which was not a nice user experience. I'd prefer to just use as_millis instead of as_seconds
plus subsec_nanos
but this is still experimental.
Either way, I'd prefer to only call .elapsed() once.
Good point. Since .elapsed() hides a call to now(), both second and nanosecond values come from different time.
I usually put a trailing comma for a multiline eprintln! invocation
Alright. I'm a trailing comma fan myself and very new to Rust.
all updated. could you have another look?
Thanks! I'll push out a new crates.io release.
Shows the average speed in the progress allowing some benchmarking before the address is found:
The speed value matches the
time
tool:14:22,91 total
is14*60+23 = 863
seconds.1892494 keys / 863 s = 2192,9 / s
, whiletime
includes starting and ending the process.