Create buffer C++ side - Githubissues

PlasmaPower / phash-image

phash for images

MIT License

55 stars 6 forks source link

Create buffer C++ side #20

Closed PlasmaPower closed 8 years ago

PlasmaPower commented 8 years ago

Resolves #1 and resolves #10

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 2d349bed504ec6294acb6587805a0fd5e0cce684 on PlasmaPower:master into e7699c68ae4391fa5430ed3db26d458c156b9225 on mgmtio:master.

PlasmaPower commented 8 years ago

First time working with C++ in Node! :tada:

PlasmaPower commented 8 years ago

I removed {u,}int_to_hex because they aren't used any more. Side note: is it possible that the ulong64 byte order is correct, and it was just being incorrectly outputted before? Fixing that would be a breaking change of course.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling e47e7d3d0b1eb80a3ed41fb4e03ad88e46e0a0fe on PlasmaPower:master into e7699c68ae4391fa5430ed3db26d458c156b9225 on mgmtio:master.

jonathanong commented 8 years ago

adding you as a collab :) not really using htis right now

PlasmaPower commented 8 years ago

@jonathanong Thanks! To be honest, the reason I made this PR was just to get the $15 bounty on #1, but I should be able to maintain this :).

jonathanong commented 8 years ago

oh thank god because i don't know how to refund that money

PlasmaPower commented 8 years ago

@jonathanong Yeah, a lot of bounties on bountysource seem to fall apart that way :P

PlasmaPower commented 8 years ago

@jonathanong Mind accepting the claim on bountysource? It will auto accept in 2 weeks, but this will be a bit easier. Link to issue on bountysource: https://www.bountysource.com/issues/5524486-create-the-node-buffer-in-c-land

PlasmaPower commented 8 years ago

@jonathanong Thanks!

jonathanong commented 8 years ago