When credentials are invalid, there is no proper information about it and GUI appears to be loading inifintely

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Configure Rhythmbox-Ampache to point to a correct URL but with invalid 
credentials
2. Go to the Ampache section in Rhythmbox
3. In the status bar, "Update songs..." will be shown (indefinitely)
4. Right-click on the Ampache entry, select the only available option "Refetch 
Ampache Library"
5. In the status bar, "Downloading songs from Ampache server..." will be shown, 
and the progress bar on the right side of the status bar will display some work 
being in progress (indefinitely)
6. If started from the command line, rhythmbox will output these error messages:
Traceback (most recent call last):
  File "/usr/lib/rhythmbox/plugins/ampache/AmpacheBrowser.py", line 288, in handshake_cb
    self.__handshake_update = datetime.strptime(handshake['update'][0:18], '%Y-%m-%dT%H:%M:%S')
KeyError: 'update'
Traceback (most recent call last):
  File "/usr/lib/rhythmbox/plugins/ampache/ampache.py", line 97, in refetch_ampache
    self.source.download_catalog()
  File "/usr/lib/rhythmbox/plugins/ampache/AmpacheBrowser.py", line 267, in download_catalog
    download_songs_chunk(0, parser, cache_file)
  File "/usr/lib/rhythmbox/plugins/ampache/AmpacheBrowser.py", line 238, in download_songs_chunk
    ampache_server_uri = '%s/server/xml.server.php?action=songs&auth=%s&offset=%s&limit=%s' % (self.settings['url'], self.__handshake_auth, offset, self.__limit)
AttributeError: 'AmpacheBrowser' object has no attribute 
'_AmpacheBrowser__handshake_auth'

What is the expected output? What do you see instead?
Expected: The ampache plugin should inform about the invalid credentials 
somehow (e.g. a message box).
Instead: The plugin appears to be still doing something

What version of the product are you using? On what operating system?
Version 0.11.1+svn34-0ubuntu1 (from distribution's repositories) on Linux Mint 
13 Maya

Please provide any additional information below.
Nothing I can think of at the moment, if there's any more information I can 
provide I'd be glad to provide it.

Original issue reported on code.google.com by froehler...@gmail.com on 5 Jan 2013 at 7:29

[GoogleCodeExporter]

nobody interested in the problem it seems? nobody else using the plugin?

Original comment by froehler...@gmail.com on 23 Jan 2013 at 9:52

[GoogleCodeExporter]

That is odd, your packages version indicates that it uses subversion revision 
r34.
Your error messages doesn't correspond with r34: line 288 is not

self.__handshake_update = datetime.strptime(handshake['update'][0:18], 
'%Y-%m-%dT%H:%M:%S')

Your version is one before to r33.

Since r33 a check was added for an empty handshake response which occurs among 
other things if the ampache receives invalid credentials and it leads to a 
message box:

Handshake response size: 0
Check ampache server logs for cause.

I suggest you ask the maintainer of the distribution to rebuild/update the 
package.

Original comment by lotan...@gmx.de on 26 Jan 2013 at 9:41

• Changed state: Fixed
• Added labels: Type-Enhancement
• Removed labels: Type-Defect