LIHEDP Notebooks - Githubissues

PlasmaPy / hack-week

2022 Hack Week material...slides,notebooks, and more

BSD 2-Clause "Simplified" License

9 stars 41 forks source link

LIHEDP Notebooks #68

Open cmoissar opened 2 years ago

cmoissar commented 2 years ago

Jupyter Notebooks from a course on Laser Plasma Interaction and High Energy Density Plasma

review-notebook-app[bot] commented 2 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

cmoissar commented 2 years ago

Note:

I am interested in pushing some of the content of these notebooks on PlasmaPy.

I believe the core functions would need to be extracted and implemented in separate .py files.

Hopefully, some of this is of interest to you:

For example, the notebook "critical_density.ipynb" aims to implement issue #26.
The "assignment_answers.ipynb" notebook uses a recent Inertial Confinement Fusion experiment at NIF,(https://doi.org/10.1038/s41566-021-00890-z) which made a lot of noise in the Fusion community, to illustrate several of the functions implemented in the other files. This may be a good example for issue #61.

cmoissar commented 2 years ago

I have a question about the difference between Pull Request and Drafts:

Can you see Drafts and comment on them?

Is it annoying for you if the Pull Request contains code that is quite rough?

pheuer commented 2 years ago

@cmoissar drafts just have a note so we know they aren't ready to review. Absolutely no problem opening a PR even when rough - it allows us to easily see what you're working on and give suggestions.

I think adding some functions for LP HEDP and an example notebook that features them would be great! I would do at as 1 PR per function and then 1 PR for the notebook. If you're still interested, you should open those PRs on the main PlasmaPy package.

JaydenR2305 commented 2 years ago

Hey @cmoissar, do you mind if I take a stab at implementing the plasma critical density formulary as my first commit?

cmoissar commented 2 years ago

Hey @cmoissar, do you mind if I take a stab at implementing the plasma critical density formulary as my first commit?

Of course not, have at it!

cmoissar commented 2 years ago

@cmoissar drafts just have a note so we know they aren't ready to review. Absolutely no problem opening a PR even when rough - it allows us to easily see what you're working on and give suggestions.

I think adding some functions for LP HEDP and an example notebook that features them would be great! I would do at as 1 PR per function and then 1 PR for the notebook. If you're still interested, you should open those PRs on the main PlasmaPy package.

Thanks for your reply. I'll (slowly) work on that after my summer break!