Plasmatree / PID-Analyzer

Other
370 stars 101 forks source link

conditional debug plotting #49

Closed bw1129 closed 5 years ago

bw1129 commented 5 years ago

I'd like to propose that the debug noise plots only plot if the debug variable contains prefiltered gyro data. This would help avoid the confusion some people have when they have unknowingly selected the incorrect debug_mode in Betaflight, resulting in meaningless results in the debug subplots. An easy way to do this is to only plot the debug subplots when the 4th column of debug[3] is empty (contains only zeros), because other debug modes fill that column, but it is empty when debug[0-2] contains prefiltered gyro data (i.e., when debug_mode=gyro_scaled; Note, ideally one might consider using debug_mode variable itself, but this wont work for certain earlier versions of BF). The solution I propose here involves 2 simple lines of code, the first (line 696) checks to see if debug[3] contains only zeros, and the second is a conditional statement (line 445) for debug subplots. There might be a more elegant way to do this, but this simple proposal is a reasonable fix.

bw1129 commented 5 years ago

closed because I have a better solution