PlasmoHQ / plasmo

🧩 The Browser Extension Framework
https://www.plasmo.com
MIT License
10.5k stars 365 forks source link

[BUG] Sass import error in Parcel 2.9.3 #786

Open joshuawalker opened 1 year ago

joshuawalker commented 1 year ago

What happened?

Importing a framework like Primer.css fails with

Cannot create property 'importer' on string 'index.scss'

This has been fixed upstream in Parcel 2.10.0: https://github.com/parcel-bundler/parcel/pull/9256

Version

Latest

What OS are you seeing the problem on?

MacOSX

What browsers are you seeing the problem on?

Chrome, Microsoft Edge

Relevant log output

TypeError: Cannot create property 'importer' on string 'index.scss'
    at loadConfig (.../node_modules/.pnpm/@parcel+transformer-sass@2.9.3_@parcel+core@2.9.3/node_modules/@parcel/transformer-sass/lib/SassTransformer.js:67:29)
    at async loadPluginConfig (.../node_modules/.pnpm/@parcel+core@2.9.3/node_modules/@parcel/core/lib/requests/ConfigRequest.js:52:21)
    at async Transformation.loadTransformerConfig (.../node_modules/.pnpm/@parcel+core@2.9.3/node_modules/@parcel/core/lib/Transformation.js:488:5)
    at async Transformation.loadPipeline (.../node_modules/.pnpm/@parcel+core@2.9.3/node_modules/@parcel/core/lib/Transformation.js:440:20)
    at async Transformation.run (.../node_modules/.pnpm/@parcel+core@2.9.3/node_modules/@parcel/core/lib/Transformation.js:146:20)
    at async Child.handleRequest (.../node_modules/.pnpm/@parcel+workers@2.9.3_@parcel+core@2.9.3/node_modules/@parcel/workers/lib/child.js:193:9)

(OPTIONAL) Contribution

Code of Conduct

louisgv commented 1 year ago

Thanks for the flag @joshuawalker - we should def upgrade to the latest Parcel upstream!