fix: Popup layout is broken and `display: flex` is unecessary

PlasmoHQ / plasmo

🧩 The Browser Extension Framework

https://www.plasmo.com

MIT License

10.14k stars 350 forks source link

fix: Popup layout is broken and `display: flex` is unecessary #831

Closed skube closed 9 months ago

skube commented 9 months ago

Besides being unnecessary it causes a layout issue (on Chrome)

Details

This PR fixes a layout issue and removes redundant code.

Code of Conduct

[x] I agree to follow this project's Code of Conduct
[x] I agree to license this contribution under the MIT LICENSE
[x] I checked the current PR for duplication.

Contacts

(OPTIONAL) Discord ID:

If your PR is accepted, we will award you with the Contributor role on Discord server.

To join the server, visit: https://www.plasmo.com/s/d

louisgv commented 9 months ago

Thanks for the PR @skube - note that this should actually be fixed in the examples repo instead. We've migrated away from the init package and the examples now bootstrap the plasmo create command :-?

skube commented 9 months ago

OK I've opened https://github.com/PlasmoHQ/examples/pull/55 instead but then noticed someone already beat me to it 🚀