Allow React to be detected in NPM Workspaces

deavial commented 7 months ago

Details

React is detected by looking for a react devDependency or dependency. NPM Workspaces (mono repos) do not define these in the project package.json. The mono repo will fail if they are defined. The mono repo root has the dependencies listed.

When looking for React in this type of environment, the peerDependencies should be inspected instead.

Code of Conduct

[x] I agree to follow this project's Code of Conduct
[x] I agree to license this contribution under the MIT LICENSE
[x] I checked the current PR for duplication.

Contacts

Discord ID: deavial

If your PR is accepted, we will award you with the Contributor role on Discord server.

To join the server, visit: https://www.plasmo.com/s/d

deavial commented 7 months ago

@louisgv any updates on this pr? currently i have to manually create a patch on minified code for each release.

louisgv commented 7 months ago

@deavial merging and releasing soon - sorry for the delay. I was trying to fix up some test and the resolver before putting this in.

PlasmoHQ / plasmo