[RFC] Change shadow dom define name - Githubissues

PlasmoHQ / plasmo

🧩 The Browser Extension Framework

https://www.plasmo.com

MIT License

8.84k stars 314 forks source link

[RFC] Change shadow dom define name #981

Open mrskiro opened 1 month ago

mrskiro commented 1 month ago

How do you envision this feature/change to look/work like?

I want to change the name of shadow dom named plasmo-csui

What is the purpose of this change/feature? Why?

Installing multiple extensions made with plasmo will cause inconvenience in element search.

(OPTIONAL) Example implementations

No response

(OPTIONAL) Contribution

[X] I would like to contribute to this RFC via a PR

Verify canary release

[X] I verified that the issue exists in plasmo canary release

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems.

mrskiro commented 3 weeks ago

Self solved.

It was to define getRootContainer and reinvent the wheel with createShadowContainer.

Perhaps an option like getShadowHostName would be more useful. Like getShadowHostId.