Closed Awayume closed 1 year ago
oooh that's good
I don't have time to review right now but will do this week
hi, sorry it took me that long to reply.
I tested on a different PR and confirm it works :D
just two things:
I prefer to use the process.env. version in the test
I think it's better to use the process.env version if it exists, to have backward compatibility: https://github.com/Platane/snk/pull/104/files#diff-4e3f58a464db9673926a95bb42e84def9a8003e7310e454edf894b3b1001cf7eR15-R16
I that's ok with you, I can merge https://github.com/Platane/snk/pull/104 which reflects that
or yours if you want to edit
Thank you for the review. I will edit my code to reflect it.
thanks you @Awayume !
The GitHub token is automatically applied to
input
as a default value. This eliminates the need to explicitly specify a token when using action.