Platane / snk

🟩⬜ Generates a snake game from a github user contributions graph and output a screen capture as animated svg or gif
https://platane.github.io/snk
4.39k stars 1.11k forks source link

svg file ruined #57

Closed AmirMGhanem closed 1 year ago

AmirMGhanem commented 1 year ago

Can anyone tell me why i am getting as output only small piece of the snake svg ?

https://github.com/AmirMGhanem/AmirMGhanem/blob/output/github-contribution-grid-snake.svg

@Platane

Zxilly commented 1 year ago

You use Platane/snk@master, just switch it to uses: Platane/snk@main Github just change their profile page structure. The outdated version no longer work. You should also update your argument.

AmirMGhanem commented 1 year ago

@Zxilly Error: Build dir does not exist

AmirMGhanem commented 1 year ago

BTW, @Zxilly also yours @ https://github.com/Zxilly/Zxilly

Zxilly commented 1 year ago

I just update it, it works now. You can follow my conf.

Platane commented 1 year ago

Thanks for the help @Zxilly

For some context, I was lazy with the versioning when I started. I did not pin the version in my workflow config.

As a lot of people copied my config, this lead to a lot of workflows automatically pulling the latest version. Which is a pain when introducing breaking changes.

When I introduced the v2 ( with breaking change ) I left the master version frozen to not impact them.

Unfortunately, today github changed the profile page markup, I fixed it on 2.2.0 . But master is frozen

Zxilly commented 1 year ago

Maybe this fix can be backport to old version.

Platane commented 1 year ago

Maybe this fix can be backport to old version.

yes, I think it needs to

AmirMGhanem commented 1 year ago

Thank you! works as Expected @Zxilly

Thanks @Platane :)