Platane / snk

🟩⬜ Generates a snake game from a github user contributions graph and output a screen capture as animated svg or gif
https://platane.github.io/snk
4.22k stars 1.03k forks source link

Action failed #75

Closed sauravhathi closed 1 year ago

sauravhathi commented 1 year ago

Generate Action failed with "Cannot read properties of undefined (reading 'split')"

74

getlost01 commented 1 year ago

Ya, this is also showing on my repo action logs.

I think there may be new changes in the GitHub API response regarding to the contribution data.

bossm0n5t3r commented 1 year ago

Same here, Is there any update?

milaabl commented 1 year ago

Same error! Worked fine yesterday.

qinchonghanzuibang commented 1 year ago

Exactly!, there is no snake now

milaabl commented 1 year ago

@Platane , please check the the return of the fetch() function. The error is coming from this block: https://github.com/Platane/snk/blob/3eed9ce6d6a473c46685bfdebd9fe02c5cbf3862/packages/github-user-contribution/index.ts#L45

It looks like GitHub updated the page https://github.com/users/user-name/contributions and I checked that now there's no js-element with "calendar-graph-svg" class.

Please see!

ithirteeng commented 1 year ago

Same error, can't wait the update :3

AzeemIdrisi commented 1 year ago

Same error.

kaisunoo commented 1 year ago

Encountering the same error, waiting for the update. Thank you!

lainbo commented 1 year ago

Same error, looking forward to an update to fix it, thanks

garyellow commented 1 year ago

Same error, waiting for the update, thx (~ ̄▽ ̄)~

BojidarDermendjiev commented 1 year ago

And here 😅

xiaotianxt commented 1 year ago

Same error here

xueweiwujxw commented 1 year ago

Same error here 😖

mwt commented 1 year ago

You shouldn't make a second issue when you know that #74 already exists.

gregWDumont commented 1 year ago

Same here!

ijsbol commented 1 year ago

This issue appears to be a duplicate of https://github.com/Platane/snk/issues/74

aelassas commented 1 year ago

Issue fixed. Check out my pull request: https://github.com/Platane/snk/pull/77

CarlosUlisesOchoa commented 1 year ago

Same here. I miss my graph ☹️

jjsair0412 commented 1 year ago

Now it working. ! ! My action history is here : https://github.com/jjsair0412/jjsair0412/actions/runs/5566243036

sauravhathi commented 1 year ago

Ya, this is also showing on my repo action logs.

I think there may be new changes in the GitHub API response regarding to the contribution data.

temporary replace

Steps uses: aelassas/snk/svg-only@main

image

milaabl commented 1 year ago

@sauravhathi , a PR with a fix doesn't mean that the issue is fixed because it has not been yet merged. This is just a temporary replacement in the workflow file.

Zaid-maker commented 1 year ago

Same issue here the actions keeps failing

sangshuduo commented 1 year ago

same here. waiting for an official solution.

Zxilly commented 1 year ago

Update crawler again and again seems not a good idea. Looks like GitHub provide a stable API to fetch contribution calendar in their GraphQL API. Why not just use it?

Platane commented 1 year ago

Hello, thanks for the quick report. I don't have my laptop at the moment. I will take a look at the proposed fixes tomorrow.

@Zxilly oh it must be new, or I missed it. I will definitely look into that thanks

xwlops commented 1 year ago

Same error here 😖

Zxilly commented 1 year ago

@Platane You can find documentation at https://docs.github.com/en/graphql/reference/objects#contributioncalendar.

https://github.com/Zxilly/animated-timeline/blob/master/src/github/calendar.ts can also be a reference.

theejkb commented 1 year ago

Ya, this is also showing on my repo action logs.

I think there may be new changes in the GitHub API response regarding to the contribution data.

temporary replace

Steps uses: aelassas/snk/svg-only@main

image

This workaround is working for me. Thanks 🔥

i'll stay updated here

SummerSec commented 1 year ago

Issue fixed. Check out my pull request: #77问题已解决。查看我的拉取请求:#77 some errors https://github.com/SummerSec/SummerSec/actions/runs/5573630774/jobs/10181168577

aelassas commented 1 year ago

@SummerSec You are generating gif with svg-only action. That's why it's failing. Try removing gif from your workflow.

Zaid-maker commented 1 year ago

I am using a temporary workflow and its works just fine

ramazansancar commented 1 year ago

Same here!

Canato commented 1 year ago

People don't need to add that it is happening to you too. It was already agreed as an issue by the repo owner. Could you just take a minute and wait for the PR to be merged?

If you want, you can react with an emoji to the first message of this issue to increase the counting. And click to subscribe to new notifications for this issue

Spamming doesn't really help =D. Have a great day ^^

Platane commented 1 year ago

some update:

I made the change suggested by @Zxilly to use the github API https://github.com/Platane/snk/pull/78/files

Unfortunately, it requires a breaking change: the action needs a github token.

I published a v3 version, which requires a token (it's a one line patch). I also published a patched v2.3 version, for the users that don't have the bandwidth to patch to v3 now