Platform-OS / platformos-documentation

Source files for the official platformOS Documentation.
https://documentation.platformos.com
Other
13 stars 31 forks source link

Add link to Contributor Guide to contribute section #1644

Closed diana-lakatos closed 1 year ago

diana-lakatos commented 1 year ago

Add a link to the Contributor Guide to the Contribute to this page section. The copy could be: "How to contribute" or "Contributor Guide".

Screenshot 2023-08-23 at 15 17 51

@GyongyGora Could you please create a design that shows what it could look like? Thank you!

GyongyGora commented 1 year ago

@diana-lakatos

I created 2 versions: https://www.figma.com/file/3M4tJDUtQEB90cIqybeV4P/Doc-site-updates?type=design&node-id=401%3A204&mode=design&t=8a441g6iXMupfK20-1

v1. Consistent with other similar sections (e.g. on landing page). This has a link under the icon, but this way the 2 columns have different height and look a bit different visually. v2. With a ? icon that could display a default tooltip when the users hovers it. In this case the 2 columns look more similar.

diana-lakatos commented 1 year ago

@GyongyGora Thank you very much! They both look great but I'd choose v2 because it's more subtle.

LukeBroadway commented 1 year ago

I can't access the figma design

GyongyGora commented 1 year ago

I can't access the figma design

@LukeBroadway Could you please check it using this link? https://www.figma.com/file/jGVHdStunTaBLMWXINGZUK/pOS-docs-design-(3)?type=design&node-id=1551%3A2102&mode=design&t=pVzVVBMxfTJiyBrn-1

I added you to Figma and sent an invite to the file too. Hopefully it will work now! :)

LukeBroadway commented 1 year ago

Added the icon and correct linking with some help from Lukasz

LukeBroadway commented 1 year ago

Maybe the icon is too big though? Let me know

GyongyGora commented 1 year ago

Yes, it should be smaller, 20x20px only (now it is 32x32) and grey. Thank you! :)

question-circle question-circle

LukeBroadway commented 1 year ago

Yep just fixed. I exported the wrong icon svg data (used the spreadsheet one instead of the edited one you linked) the position/size looks good on windows and phone view