search

PlatformLab / HomaModule

A Linux kernel module that implements the Homa transport protocol.
175 stars 43 forks source link

Fix `vlan` IP RegEx #32

Closed HarshKapadia2 closed 1 year ago

HarshKapadia2 commented 1 year ago

CloudLab's xl170 machines have an interface ens1f1np1 with the IPs in the range 10.10.1.0/24 (as seen in the image below), but the Regular Expression in cloudlab/bin/config script checks for ^[ ]+ inet 10\.0\.1\. rather than ^[ ]+ inet 10\.10\.1\.. This PR is to correct that, as the existing script cannot assign the vlan value and causes the script to error out.

image

johnousterhout commented 1 year ago

Sorry for my slow response. I am seeing a different network configuration on the xl170 nodes that I use:

ouster@node1:~$ ifconfig
eno49np0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet 128.110.218.153  netmask 255.255.248.0  broadcast 128.110.223.255
        inet6 fe80::9af2:b3ff:feca:21a0  prefixlen 64  scopeid 0x20<link>
        ether 98:f2:b3:ca:21:a0  txqueuelen 1000  (Ethernet)
        RX packets 33630  bytes 2141224 (2.1 MB)
        RX errors 0  dropped 4  overruns 0  frame 0
        TX packets 1264  bytes 176120 (176.1 KB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

ens1f1np1: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet6 fe80::9edc:71ff:fe5d:f041  prefixlen 64  scopeid 0x20<link>
        ether 9c:dc:71:5d:f0:41  txqueuelen 1000  (Ethernet)
        RX packets 82  bytes 11836 (11.8 KB)
        RX errors 0  dropped 1  overruns 0  frame 0
        TX packets 92  bytes 13807 (13.8 KB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

lo: flags=73<UP,LOOPBACK,RUNNING>  mtu 65536
        inet 127.0.0.1  netmask 255.0.0.0
        inet6 ::1  prefixlen 128  scopeid 0x10<host>
        loop  txqueuelen 1000  (Local Loopback)
        RX packets 70  bytes 5603 (5.6 KB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 70  bytes 5603 (5.6 KB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

vlan395: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet 10.0.1.2  netmask 255.255.255.0  broadcast 10.0.1.255
        inet6 fe80::c8:69ff:fe96:80ee  prefixlen 64  scopeid 0x20<link>
        ether 02:c8:69:96:80:ee  txqueuelen 1000  (Ethernet)
        RX packets 79  bytes 10538 (10.5 KB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 80  bytes 12504 (12.5 KB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

First, I have a vlan in addition to ens1f1np1, whereas it appears you don't, and second, my vlan IP addresses are 10.0.1.N whereas it appears your (non-vlan) addresses are 10.10.1.N. These IP addresses are determined by your Cloudlab profile; can you change your profile to use 10.0.1.N addresses instead?

johnousterhout commented 1 year ago

I'm closing this PR, since it looks like the best solution is to be consistent in the IP addresses assigned by CloudLab profiles.