search

PlatformLab / grpc_homa

Allows Homa to be used as a transport with gRPC.
27 stars 5 forks source link

grpc::ServerContextBase::peer() returns "unknown" #11

Closed mikehb closed 1 year ago

mikehb commented 1 year ago

https://github.com/PlatformLab/grpc_homa/files/12864623/homa.tar.gz

In the test program above, ctx_.peer() returns unknown for HOMA on server side, while it returns 127.0.0.1:4000 for TCP

johnousterhout commented 1 year ago

Thanks for reporting this. It seems that gRPC has an undocumented requirement that transports create an extra metadata value for the peer address when messages arrive; I've added support for this, and your test case now works for me. I have pushed this fix to GitHub. Let me know whether it works for you too?

mikehb commented 1 year ago

It works for me now. Thanks

johnousterhout commented 1 year ago

Excellent; glad to hear it.