search

PlatformLab / grpc_homa

Allows Homa to be used as a transport with gRPC.
25 stars 5 forks source link

grpc::ServerContextBase::peer() returns "unknown" #11

Closed mikehb closed 10 months ago

mikehb commented 11 months ago

https://github.com/PlatformLab/grpc_homa/files/12864623/homa.tar.gz

In the test program above, ctx_.peer() returns unknown for HOMA on server side, while it returns 127.0.0.1:4000 for TCP

johnousterhout commented 10 months ago

Thanks for reporting this. It seems that gRPC has an undocumented requirement that transports create an extra metadata value for the peer address when messages arrive; I've added support for this, and your test case now works for me. I have pushed this fix to GitHub. Let me know whether it works for you too?

mikehb commented 10 months ago

It works for me now. Thanks

johnousterhout commented 10 months ago

Excellent; glad to hear it.