PlatformOfTrust / collected-feedback

Feedbacks and Wishlist for Platform of Trust are collected as issues in this repository.
0 stars 1 forks source link

Ontology viewer link to point to production version #50

Closed ralupopa closed 3 years ago

ralupopa commented 3 years ago

Describe the Pain you found while using Developer Portal

On guides published before ontology was released ontology viewer has links towards ontotest environment. now that ontology v2 production is published, guides should be updated to have production links: instead of base uri https://standards-ontotest.oftrust.net/v2/ should be https://standards.oftrust.net/v2/ Also, maybe the code examples the values for @context could be updated since they are either lifeengine of v1 platform of trust ontology.

Guides to update:

image

And on https://developer.oftrust.net/guides/identity-and-data-discovery/#data-products-discovery

image

I have checked other guides and they were using production not ontotest, as expected.

An example from this guide https://developer.oftrust.net/guides/integrate-data-source-60-minutes/#step-3-create-a-group where context could be updated (Register an application): image

Indicate the importance with a number

3 (1. Critical, 2. Important, 3. Nice-to-have)

Nazarah commented 3 years ago

@ralupopa tried to fix the context links as much as possible. However, few things I didn't edit, because I was unsure if the new value would be correct:

  1. https://developer.oftrust.net/guides/identity-and-data-discovery/#link-context-and-direction -> pagination links in different response bodies. e.g:
    {
        "rel": "first",
        "href": "https://api-sandbox.oftrust.net/identities/v1/discovery?offset=0&limit=20&linkContext=https%3A%2F%2Fstandards.oftrust.net%2Fv1%2FContext%2FLink%2FLocatedAt%2F&fromId=170bb798-0f91-498d-8fa5-7b690cd1a1ca&identityContext=https%3A%2F%2Fstandards.oftrust.net%2Fv1%2FContext%2FIdentity%2FDevice%2FSensor%2F&linkDirection=IN&maxDepth=5"
      }
  2. https://developer.oftrust.net/guides/identity-and-data-discovery/#data-products-discovery -> translator public key
    "organizationPublicKeys": [
    {
      "type": "RsaSignature2018",
      "url": "https://api-sandbox.lifeengine.io/translator/v1/public.key"
    }
    ],

    If something is missing, please list it out. Otherwise, please close the issue after you have verified it. Thanks. :)

ralupopa commented 3 years ago

@Nazarah Thank you for the related fixes. Here is what I found:

  1. The actual links of ontology viewer which are still pointing towards ontotest:

  2. In guide https://developer.oftrust.net/guides/identity-and-data-discovery/#identities-discovery I see that the example of linkContext is from v1 of ontology. Let's change it to v2 to be consistent with the rest?

image

  1. About the context links from the examples, I see you have changed from lifeengine ones, but platform of trust v1 are still present. Would it be good to have the actual context links from v2?

image

Nazarah commented 3 years ago

@ralupopa done. If there is nothing more to fix, you can close the issue. :)

ralupopa commented 3 years ago

@Nazarah just one more I could spot : image

Nazarah commented 3 years ago

@ralupopa sorry for the late fix. closing the issue. If new things are found, please reopen and tag me. :')